From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BD3A71FF3B2 for ; Fri, 7 Jun 2024 13:01:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9915B1D516; Fri, 7 Jun 2024 13:01:23 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Fri, 7 Jun 2024 18:33:13 +0900 X-Mailman-Approved-At: Fri, 07 Jun 2024 13:01:21 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Jing Luo via pve-devel Precedence: list Cc: Jing Luo X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-common] tools: fix syscall mknod() Content-Type: multipart/mixed; boundary="===============3318210768424691775==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============3318210768424691775== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 76497C88A1 for ; Fri, 7 Jun 2024 11:48:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EE8F1C3A1 for ; Fri, 7 Jun 2024 11:48:45 +0200 (CEST) Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jun 2024 11:48:44 +0200 (CEST) Received: from mail-gw3.jing.rocks (localhost [127.0.0.1]) by mail-gw3.jing.rocks (Proxmox) with ESMTP id 5DAC5161B3 for ; Fri, 7 Jun 2024 18:40:17 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc :cc:content-transfer-encoding:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=mail-gw; bh=eVCI aQAez7TZnLWMRHL7AUIugBiLZM379xLoBN2sAXM=; b=ch6zg9mVgvZ8+dbG4sAz oymrhPoq93O72RojrpRwyMI79wiv3Fl5WsbWUs2rM9/f2j1rrjouKJTQ7qZ84/x/ +HpTJgYOSa4r8hBrnkEpfxcvqiUIKk2WEKl7zpzf224enwCxEBxHXUTbJe0N0ciW 1yiWYPTW8J7AWRlfOgo+0OK/3bmXUnut3OO73IBuJQXg5yGoRF/ZuRujBdThkx50 UUsZuuSKSb27MVJ+YhUY70YJAkxcLGlj7pxKMkug/HQ6zh1Uv3g/gwG6GxQq1sHD rVA6G7+xrMZR0xZjeYADDgOkYuiOdBIagmHTafLAAwKe9J2O9Hpf9TmNx/kzN3PX mA== Received: from mail.jing.rocks (mail.jing.rocks [192.168.0.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail-gw3.jing.rocks (Proxmox) with ESMTPS id 540441623F for ; Fri, 7 Jun 2024 18:40:15 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks; s=default; t=1717753215; bh=QFObgG1IYI9NpKxLTHSDrxTU5Dr3nchJliOzLqPiAVc=; h=From:To:Cc:Subject:Date:From; b=RC5hTmqd+vA64PCANWEriqyYB3uYYgyJcy7VQhsPlhcGrx5xSYlRCclG2bQoUyArA p+9soIYyMhnjUpgym/fVxJvuc5gPoZjDV1sH8Dkg6NCrp7TGUVA8/Hzjd5tE1OoHpT zjE4BW5ZXhN7mUasq3fJh1yir0Ku9YZGkuLNB3uO62E0IU5o0mo6wYwAEAq9iJlOf+ jIjEIeM9tKwHU/nHt1RD6QIBlUM2S9pegiVIOYQp5vnS4GLG7VqbNSc7WE2VCtjZ9b 392ykTJDBJqM837jmKDJdfB4F2s5eJwSewKDcVa3EN/fQXDVCUInlwMmN+5ShbW+Wm CUZHOECE+kSlQ== Received: from X570AM.jing.rocks (unknown [IPv6:240b:10:f00:1b00::7e82]) (Authenticated sender: jing@jing.rocks) by mail.jing.rocks (Postfix) with ESMTPSA id 3D128346F0; Fri, 7 Jun 2024 18:40:15 +0900 (JST) From: Jing Luo To: pve-devel@lists.proxmox.com Cc: Jing Luo Subject: [PATCH pve-common] tools: fix syscall mknod() Date: Fri, 7 Jun 2024 18:33:13 +0900 Message-ID: <20240607093933.3882526-2-jing@jing.rocks> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware KAM_OTHER_BAD_TLD 0.75 Other untrustworthy TLDs SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - X-Mailman-Approved-At: Fri, 07 Jun 2024 13:01:21 +0200 b792e8df81 introduced a bug that can cause this: Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11 It should be mknod, not SYS_mknod. This caused other pve perl lib failing to build. I couldn't reproduce this on amd64 build, but I could reproduce this on arm64 build; however this didn't seem to fix the issue, unless I revert b792e8df81. cf: b792e8df81d70cc8fc4bc7d0655313d4a7f40c3d Signed-off-by: Jing Luo --- src/PVE/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 766c809..c2906de 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -1753,7 +1753,7 @@ sub mkdirat($$$) { sub mknod($$$) { my ($filename, $mode, $dev) = @_; - return syscall(PVE::Syscall::SYS_mknod, $filename, int($mode), int($dev)) == 0; + return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0; } sub fchownat($$$$$) { -- 2.45.2 --===============3318210768424691775== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============3318210768424691775==--