From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0011A1FF161 for ; Tue, 22 Oct 2024 11:51:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E4699B77; Tue, 22 Oct 2024 11:51:53 +0200 (CEST) References: <7682adb7-3cff-4af5-80e1-54bc307b03da@proxmox.com> In-Reply-To: <7682adb7-3cff-4af5-80e1-54bc307b03da@proxmox.com> Date: Tue, 22 Oct 2024 11:51:31 +0200 To: Proxmox VE development discussion MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Esi Y via pve-devel Precedence: list Cc: Esi Y X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH SERIES v2 pve-storage/qemu-server] add external qcow2 snapshot support Content-Type: multipart/mixed; boundary="===============4610412962132235122==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============4610412962132235122== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15E1EC762F for ; Tue, 22 Oct 2024 11:51:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0BB59B3A for ; Tue, 22 Oct 2024 11:51:50 +0200 (CEST) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 22 Oct 2024 11:51:49 +0200 (CEST) Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-e291f1d659aso4924053276.3 for ; Tue, 22 Oct 2024 02:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729590702; x=1730195502; darn=lists.proxmox.com; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JweE14T57w2g4Bw2QKpZvHKAJ7XC7RvECI7fD3t/4Uk=; b=nHhfeOZ37YoOcCyh6U3Tc6bF37wNdt+9aA3nMCSFTXxi10L55GCwVKPkYDJobduXwO 7b6Flxu6NX4Ab40SYHmnkIgAnlgs9UBGXbJfiNdIwea+/ajgzf4MXY/aJzfp4zA3vYOT 46VasZLW4myuEtgD/8oEtwd0FwDgZNVLMAvHcmkaUxUG20Zm390gmLgUdtokAbu+LRnS ds8k/M1daG+MFv7eJMrFO1tNHEGXx6S+qQlgi7M6nRMraifkSHJFQ99ITYAgMVvJqckZ hHlMkm4/rqv+mEbpEDZXpMCpg+Dui86QVDzhLnXn7TPBewVEe8WH5pSx0NS4wnGi8zYX kogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729590702; x=1730195502; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JweE14T57w2g4Bw2QKpZvHKAJ7XC7RvECI7fD3t/4Uk=; b=m0sA4jmmk+ZsXS97c5AdLYIM2xF4PHH7jBCKaUkAWlg7A3qO5+DEpyGMMWmvbKTi08 Ks63uVwBYup5CoXRUm2S/1h8lZRNnYaqchL+KSzdq/2ukf4Xw2RaPBbZIKe3U0I8cHtd bydb+9okPEUMlzRnbUxoCsuC74O8STH1jUeJD1zg2L7P9op3LNtPwzl3hw9vOxXpQSkq a0Gc0KV71fyXAFe5kGnvV8Fp9sQCitru7nQ7XRDAOHIwJ+nThdCmaq44fZdyOI9Qe6dd /m98py/nnN7Mg21WsH4yhY/Q9ZFZWHXJA8ykSqMcVdPV5XR6q29YbGZ9Owcd2hYv8qIm v6ZQ== X-Gm-Message-State: AOJu0Yxa/UdQAAz8J7U8Ddm3HysIzXLhS+fwzE9JVsqxLBVT3vDlRHgc HGLH2xgli5IWkZ2898sjrkDN8wqpQ1S9Fmbc+PI7sDKn5CgpG6S5q63m7lckMWdFb+FssydVgtb +1uI6DyT8DRBMM96JEsFfEGypnL2IwrRD X-Google-Smtp-Source: AGHT+IHIaxMEVcSCO09ibOwl9pypCVFke5RYUkE0+2+VjhYTmAZ01HK+ImkdyGeUnBBB91NaqEv6ZgNLwwzPddxUIL0= X-Received: by 2002:a05:6902:1004:b0:e25:ce87:6437 with SMTP id 3f1490d57ef6-e2bb169078cmr12074483276.44.1729590702550; Tue, 22 Oct 2024 02:51:42 -0700 (PDT) MIME-Version: 1.0 References: <7682adb7-3cff-4af5-80e1-54bc307b03da@proxmox.com> In-Reply-To: <7682adb7-3cff-4af5-80e1-54bc307b03da@proxmox.com> From: Esi Y Date: Tue, 22 Oct 2024 11:51:31 +0200 Message-ID: Subject: Re: [pve-devel] [PATCH SERIES v2 pve-storage/qemu-server] add external qcow2 snapshot support To: Proxmox VE development discussion Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.200 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 0.25 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record On Tue, Oct 22, 2024 at 8:39=E2=80=AFAM Thomas Lamprecht wrote: > The thing you linked has not only nothing to do with the snapshots of the > qcow2 format, which are just one of the targets, it also nowhere states > what you crudely try to imply. It's 2016 wiki: "Internal snapshots to images which support internal snapshots (QCOW2 & QED) are not expected to be supported initially." "By making the snapshot-file argument of the monitor and QMP command optional, that could be used as a request to make the snapshot internally instead of to an external file. However, without live block migration of an internal snapshot, there is no way to make a backup of an internal snapshot while still leaving the VM running, so this feature is not planned at the present. For now, the snapshot-file argument is required, and only external snapshots are implemented." > wasting developers time that then, among other things, delays actual I hoped this would bump it up for Alexandre to get a response. --===============4610412962132235122== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============4610412962132235122==--