From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6E1411FF183 for ; Wed, 30 Jul 2025 23:35:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CEC81AC48; Wed, 30 Jul 2025 23:36:45 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 23:26:13 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: =?utf-8?q?Trygve_Laugst=C3=B8l_via_pve-devel?= Precedence: list Cc: =?UTF-8?q?Trygve=20Laugst=C3=B8l?= X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-network 0/1] ipam/netbox prefix fix Content-Type: multipart/mixed; boundary="===============8129488937704950827==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============8129488937704950827== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 75693CECB2 for ; Wed, 30 Jul 2025 23:36:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 43D471AC7E for ; Wed, 30 Jul 2025 23:36:13 +0200 (CEST) Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 30 Jul 2025 23:36:11 +0200 (CEST) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7CBCE7A100D; Wed, 30 Jul 2025 17:26:21 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Wed, 30 Jul 2025 17:26:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inamo.no; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm3; t=1753910781; x=1753997181; bh=nq DRHNJx3CRHFkvNLRCNa2ETbYCQob9rQgBhENSE9D4=; b=kFrtsKt8KMEYSCXgvC OCNmBBMYXUdqePOLjGEHXo4N2s8qaW/JZPl6agvUVTI7Rtemzz+MWDptuxnmG3gD xR4gWr0lww9UDit7mrwEeZJUbOFlNeDXCoOQlAGIEFjf3oPwOCUmp/QsYJx4Cm/o q6R1QeoZj39zOyUp+3rvNhUnCsd3scAPJaxrGGai1B+98dVdoZYMTgsgz85i5l5N Xr1ZDfvbG7olxtbMgCUniVn0VSQois6VQGQu0dAK3LXBiuFnO+p64KJgSPFl79v4 BlOPxsnHf2afEc+UtTWYDySzCgP3jC4s9UebWNQIAlN5KNck3O2ooejTnizmSrFT Obrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1753910781; x=1753997181; bh=nqDRHNJx3CRHFkvNLRCNa2ETbYCQ ob9rQgBhENSE9D4=; b=PgpLil7h794vWjCmrwvFTntooVzLI6nlI+OIoMNEDfrx cpd5woXlU5AmMAbvBVa/oCdYO1J6Rr9CLYDzdzk7Md28nkv/AOUMcfOyL9hV59Re iGg2KJmPVdYX18Jjx8gTKZIBDx1m8oKzUxNQTw7CJPU5D2MlyQzzE85yKJ8tgDd1 OjM/tVTWjBruv46bE38nO67ML5OMOBG0dBf3xZsEmDJdmTXBnQRk14FvLtj7IxrD mrQcfB6ok1wfbex9/L00Q1hPw3Z0B9ygB1wMWN7lWOQzEm7ajom+RwQL4n96lUj/ 1Hs7tYwVYZ3ALCuzJvRW1PxYvnYnHAKej2z2g9+m6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdelledttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertdertd ejnecuhfhrohhmpefvrhihghhvvgcunfgruhhgshhtpphluceothhrhihgvhhishesihhn rghmohdrnhhoqeenucggtffrrghtthgvrhhnpeekffekjeetveejleeuheelkeekgeegff ejieeuudektedtfeefvdethfdthefffeenucffohhmrghinhepphhrohigmhhogidrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtrh ihghhvihhssehinhgrmhhordhnohdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhht phhouhhtpdhrtghpthhtohepphhvvgdquggvvhgvlheslhhishhtshdrphhrohigmhhogi drtghomhdprhgtphhtthhopehtrhihghhvihhssehinhgrmhhordhnoh X-ME-Proxy: Feedback-ID: i6cf1495c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Jul 2025 17:26:20 -0400 (EDT) From: =?UTF-8?q?Trygve=20Laugst=C3=B8l?= To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network 0/1] ipam/netbox prefix fix Date: Wed, 30 Jul 2025 23:26:13 +0200 Message-ID: <20250730212614.1264010-1-trygvis@inamo.no> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.614 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy JMQ_SPF_NEUTRAL 0.5 SPF set to ?all RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [inamo.no,netboxplugin.pm,messagingengine.com,proxmox.com] This fixes #6569 [1]. It basically changes the Netbox lookup from a search to a lookup. In Netbox it is possible to have multiple registrations of the same prefix as long as they belong to different VRFs, which is a case this patch also covers. I'm not entirely sure the current logic by failing if the prefix exists is the best, it's easy to think of cases where the prefixes would be planned in Netbox first (either manually or via automation). But I guess that is a discussion for another day. This is my first patch to Proxmox, please let me know if I should do things in a different way. I will sign the CLA in the following days when I have access to a scanner. [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=6569 [2]: https://git.proxmox.com/?p=pve-network.git;a=blob;f=src/PVE/Network/SDN/Ipams/NetboxPlugin.pm;h=e118d03e1eb062d0b69cbb53bb7eb875a1e55336;hb=ea6db24afdaf63dedcdd4d74ce97918f7f82b034#l81 Trygve Laugstøl (1): fix #6569: ipam: netbox: better prefix lookup src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.47.2 --===============8129488937704950827== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============8129488937704950827==--