From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E0B3B1FF15F for ; Mon, 26 Aug 2024 13:01:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04065112BF; Mon, 26 Aug 2024 13:00:49 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Mon, 26 Aug 2024 13:00:24 +0200 In-Reply-To: <20240826110030.1744732-1-alexandre.derumier@groupe-cyllene.com> References: <20240826110030.1744732-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-storage 3/5] add volume_underlay_resize Content-Type: multipart/mixed; boundary="===============2002634524582616259==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============2002634524582616259== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 782CFC68D9 for ; Mon, 26 Aug 2024 13:00:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A53F10D5C for ; Mon, 26 Aug 2024 13:00:44 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Aug 2024 13:00:41 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 3D7828267D6; Mon, 26 Aug 2024 13:00:33 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 0FC6A102034F; Mon, 26 Aug 2024 13:00:32 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 3/5] add volume_underlay_resize Date: Mon, 26 Aug 2024 13:00:24 +0200 Message-Id: <20240826110030.1744732-7-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240826110030.1744732-1-alexandre.derumier@groupe-cyllene.com> References: <20240826110030.1744732-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.249 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Allow to resize the underlay vm volume Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 18 ++++++++++++++++++ src/PVE/Storage/LVMQcow2Plugin.pm | 12 ++++++++++++ src/PVE/Storage/Plugin.pm | 7 +++++++ 3 files changed, 37 insertions(+) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 385150e..8e0f8f1 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -317,6 +317,24 @@ sub volume_resize { } } +sub volume_underlay_resize { + my ($cfg, $volid, $size) = @_; + + my $padding = (1024 - $size % 1024) % 1024; + $size = $size + $padding; + + my ($storeid, $volname) = parse_volume_id($volid, 1); + if ($storeid) { + my $scfg = storage_config($cfg, $storeid); + my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); + return $plugin->volume_underlay_resize($scfg, $storeid, $volname, $size); + } elsif ($volid =~ m|^(/.+)$| && -e $volid) { + die "resize file/device '$volid' is not possible\n"; + } else { + die "unable to parse volume ID '$volid'\n"; + } +} + sub volume_rollback_is_possible { my ($cfg, $volid, $snap, $blockers) = @_; diff --git a/src/PVE/Storage/LVMQcow2Plugin.pm b/src/PVE/Storage/LVMQcow2Plugin.pm index 2a56c46..3b98eeb 100644 --- a/src/PVE/Storage/LVMQcow2Plugin.pm +++ b/src/PVE/Storage/LVMQcow2Plugin.pm @@ -191,6 +191,18 @@ sub volume_snapshot_delete { return PVE::Storage::Plugin::volume_snapshot_delete($class, $scfg, $storeid, $volname, $snap, $running); } +sub volume_underlay_resize { + my ($class, $scfg, $storeid, $volname, $size) = @_; + + my $path = $class->filesystem_path($scfg, $volname); + + $size = ($size/1024/1024) . "M"; + my $cmd = ['/sbin/lvextend', '-L', $size, $path]; + + #don't use global cluster lock here, use on native local lvm lock + run_command($cmd, errmsg => "error resizing volume '$path'"); +} + sub volume_has_feature { my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_; diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 6444390..e930102 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1071,6 +1071,13 @@ sub volume_resize { return undef; } +sub volume_underlay_resize { + my ($class, $scfg, $storeid, $volname, $size) = @_; + + # do nothing by default + return undef; +} + sub volume_snapshot { my ($class, $scfg, $storeid, $volname, $snap) = @_; -- 2.39.2 --===============2002634524582616259== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============2002634524582616259==--