From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id EC17E1FF15C
	for <inbox@lore.proxmox.com>; Fri, 13 Jun 2025 18:42:24 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 287A813F98;
	Fri, 13 Jun 2025 18:42:49 +0200 (CEST)
Date: Fri, 13 Jun 2025 17:42:13 +0100
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>, 
 "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
References: <mailman.197.1748937402.395.pve-devel@lists.proxmox.com>
 <mailman.283.1749205068.395.pve-devel@lists.proxmox.com>
 <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com>
 <5sqpzsnyzmfvvoco3ilo6tg3pcpomhle7h5dsnmbsbdjobpr5a@rqfsbsas36e2>
 <8cbed06bbe3db00e96670dec1e240123b946a917.camel@groupe-cyllene.com>
 <a7185aa585b414710be6e09729adda57ed3787b8.camel@groupe-cyllene.com>
In-Reply-To: <a7185aa585b414710be6e09729adda57ed3787b8.camel@groupe-cyllene.com>
MIME-Version: 1.0
Message-ID: <mailman.376.1749832968.395.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: "joao.sousa--- via pve-devel" <pve-devel@lists.proxmox.com>
Precedence: list
Cc: "joao.sousa@eurotux.com" <joao.sousa@eurotux.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu]
 add external qcow2 snapshot support
Content-Type: multipart/mixed; boundary="===============1010156738150102179=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============1010156738150102179==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <joao.sousa@eurotux.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id E14B1CDDB5
	for <pve-devel@lists.proxmox.com>; Fri, 13 Jun 2025 18:42:47 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B00AC13EE0
	for <pve-devel@lists.proxmox.com>; Fri, 13 Jun 2025 18:42:17 +0200 (CEST)
Received: from eurotux.com (mail.eurotux.com [185.98.249.9])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Fri, 13 Jun 2025 18:42:15 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by eurotux.com (Postfix) with ESMTP id CCAC530C6F8B;
	Fri, 13 Jun 2025 17:42:14 +0100 (WEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eurotux.com; h=
	in-reply-to:content-disposition:content-type:content-type
	:mime-version:references:message-id:subject:subject:from:from
	:date:date; s=default; t=1749832934; x=1751647335; bh=jZn1z9l45W
	QihxIqDLJepq9aVKa5umZ5G/k8NzqAQgg=; b=UsjHPXQXczOEFVwS1T792wBjiR
	DgTt1B8Cjeo7b4OIepLAojOJbXOw7K4vLCPh3zWx/8qbQ10UC27/pJ7/xu0Tm4OU
	ekLVRCE6sGF8qF+svTybkij7TbG2s9SaeVgLZ1wDeCHKCEsk9/e414oKsy+BRaej
	417tgqvXASy/puzHjdMSJHiy7FOXxZmCyduuqtmC+fSBuSsfBckgb35RKEEjE2kH
	EuTYobRRKCC9zmiKzHD8d/V5xsVmIgqbtNQ4uT0mzGOxyYUArUV1L3/riKzz/xhj
	O/va1CO7CnsBfgzKYA456zJQOn1nfwg40FN5w2bANu89SwYFimlXGVQmKnbQ==
X-Virus-Scanned: amavisd-new at mail.prd.eurotux.pt
Received: from eurotux.com ([127.0.0.1])
 by localhost (mail.prd.eurotux.pt [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id piSyueKswFtv; Fri, 13 Jun 2025 17:42:14 +0100 (WEST)
Received: from localhost (brg.eurotux.com [185.98.249.5])
	(Authenticated sender: joao.sousa@eurotux.com)
	by eurotux.com (Postfix) with ESMTPSA id F371330C597F;
	Fri, 13 Jun 2025 17:42:13 +0100 (WEST)
Date: Fri, 13 Jun 2025 17:42:13 +0100
From: "joao.sousa@eurotux.com" <joao.sousa@eurotux.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>, 
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu]
 add external qcow2 snapshot support
Message-ID: <qss36oltvd4gz5tiss7dqono5h2zmsgwmodj4cqkroboizypwj@kbyz3mymh75a>
References: <mailman.197.1748937402.395.pve-devel@lists.proxmox.com>
 <mailman.283.1749205068.395.pve-devel@lists.proxmox.com>
 <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com>
 <5sqpzsnyzmfvvoco3ilo6tg3pcpomhle7h5dsnmbsbdjobpr5a@rqfsbsas36e2>
 <8cbed06bbe3db00e96670dec1e240123b946a917.camel@groupe-cyllene.com>
 <a7185aa585b414710be6e09729adda57ed3787b8.camel@groupe-cyllene.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a7185aa585b414710be6e09729adda57ed3787b8.camel@groupe-cyllene.com>
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.036 Adjusted score from AWL reputation of From: address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	SPF_HELO_PASS          -0.001 SPF: HELO matches SPF record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [eurotux.com,proxmox.com]

On 12/06/25 11:33, DERUMIER, Alexandre wrote:
> here the patch series:
> https://lists.proxmox.com/pipermail/pve-devel/2024-August/065201.html
Thanks I'll definitely be checking it out.

> The idea is to create a lvm volume smaller than the real qcow2 size,
>
> qemu is sending an event when the used space reach a threshold,
>
> then a daemon should resize the lvm volume by increment.(1GB for
> example),
> until the next threshold reach....

I was thinking the same way (probably influenced by oVirt's way of
achieving this)

> The only complex thing is to manage some kind of queue in this daemon
> and manage
> lvm cluster lock, as we can't resize multiple lvm volume at the same
> time.
> (Not sure if it need a central daemon, or a distributed daemon on each
> node with a shared queue in /etc/pve ...)

The solution that makes the most sense to me at the moment would be a
"distributed daemon", as in a daemon running on each node of the
cluster. Each node would maintain its own local queue for disk extends
related to the VMs hosted there. When an extend is needed, the node would
acquire the storage lock, perform the task, and then release the lock
so other nodes can proceed with their operations.

What are your thoughts on this approach?

The help is much appreciated :)


--===============1010156738150102179==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============1010156738150102179==--