From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AEC801FF17C for <inbox@lore.proxmox.com>; Wed, 11 Jun 2025 23:28:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9729FFC89; Wed, 11 Jun 2025 23:28:56 +0200 (CEST) Date: Wed, 11 Jun 2025 22:28:42 +0100 To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <mailman.197.1748937402.395.pve-devel@lists.proxmox.com> <mailman.283.1749205068.395.pve-devel@lists.proxmox.com> <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com> In-Reply-To: <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com> MIME-Version: 1.0 Message-ID: <mailman.340.1749677335.395.pve-devel@lists.proxmox.com> List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Post: <mailto:pve-devel@lists.proxmox.com> From: "joao.sousa via pve-devel" <pve-devel@lists.proxmox.com> Precedence: list Cc: "joao.sousa" <joao.sousa@eurotux.com> X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support Content-Type: multipart/mixed; boundary="===============0781292214643275244==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> --===============0781292214643275244== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: <joao.sousa@eurotux.com> X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EEFE5CD523 for <pve-devel@lists.proxmox.com>; Wed, 11 Jun 2025 23:28:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D36E6FBD6 for <pve-devel@lists.proxmox.com>; Wed, 11 Jun 2025 23:28:54 +0200 (CEST) Received: from eurotux.com (mail.eurotux.com [185.98.249.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 11 Jun 2025 23:28:53 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by eurotux.com (Postfix) with ESMTP id 882B730C6F82; Wed, 11 Jun 2025 22:28:43 +0100 (WEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eurotux.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date; s=default; t=1749677322; x=1751491723; bh=D5X5yHXF+P PqcvBwXiVKBBz1Wd37Cf4ufb2WPq5Aa7c=; b=BbovgZrVw5tu9t2CRJAYS8kilr d55oXpXGw3wNUSZ08Zg5dOSv46HmD7wpikPPxrkRqujATrIkqfc/mX14VEhhHqeN CJSMwXxJyyIAX8Opk/QswUDATyQuX50mLmlCcaPBCjHOXxsLwNIzFn4jOLNcmgw1 MVaMbTal0u3T2aw/9qLg8biCjygMPmlnQCO5+PhTMfoA6H8WKlcK7/jObQ6XI6Bi aSGPhylUfHTzIOazUZbQ+e+YdZFmq7cUTC1XeDcfygnwptdPfpF7j/gJZA4aeyRT Q9CVV/Du3rpcLP9rbFojG8LMHW7I+NyhmZBIgG5Pg/UT/4Sn9fju3066nNeA== X-Virus-Scanned: amavisd-new at mail.prd.eurotux.pt Received: from eurotux.com ([127.0.0.1]) by localhost (mail.prd.eurotux.pt [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XKjucEdeNOLk; Wed, 11 Jun 2025 22:28:42 +0100 (WEST) Received: from localhost (brg.eurotux.com [185.98.249.5]) (Authenticated sender: joao.sousa@eurotux.com) by eurotux.com (Postfix) with ESMTPSA id D78F530BF981; Wed, 11 Jun 2025 22:28:42 +0100 (WEST) Date: Wed, 11 Jun 2025 22:28:42 +0100 From: "joao.sousa" <joao.sousa@eurotux.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support Message-ID: <5sqpzsnyzmfvvoco3ilo6tg3pcpomhle7h5dsnmbsbdjobpr5a@rqfsbsas36e2> References: <mailman.197.1748937402.395.pve-devel@lists.proxmox.com> <mailman.283.1749205068.395.pve-devel@lists.proxmox.com> <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record On 10/06/25 10:54, Fiona Ebner wrote: > What exactly is your goal with the feature? If you want to build > something on top of it, it might be better to wait until it is > finalized/applied. Currently, the most helpful contribution with the > feature itself would be testing and reviewing Alexandre's changes. For > testing, you'll need to apply the changes and build and install the > affected packages. Reviewing requires getting familiar with the code > base first. For now, I want to help agile the process of getting the feature to a stable state. Later on, I'd like to contribute to a version which enables thin provisioned snapshots. Regarding the testing, I am having a little bit of trouble applying the current patches. This is the output of git am when applying the qemu-server patches: Applying: blockdev: cmdline: add blockdev syntax support .git/rebase-apply/patch:972: trailing whitespace. boot: error: patch failed: test/cfg2cmd/simple-btrfs.conf.cmd:32 error: test/cfg2cmd/simple-btrfs.conf.cmd: patch does not apply error: patch failed: test/cfg2cmd/simple-rbd.conf.cmd:34 error: test/cfg2cmd/simple-rbd.conf.cmd: patch does not apply error: patch failed: test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd:32 error: test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd: patch does not apply Patch failed at 0001 blockdev: cmdline: add blockdev syntax support hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". It also happens when applying the pve-storage patches. Am I missing something? --===============0781292214643275244== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============0781292214643275244==--