From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 11E821FF18A
for <inbox@lore.proxmox.com>; Sun, 30 Mar 2025 18:32:52 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 21147363A5;
Sun, 30 Mar 2025 18:32:42 +0200 (CEST)
To: pve-devel@lists.proxmox.com
Date: Mon, 31 Mar 2025 01:28:49 +0900
MIME-Version: 1.0
Message-ID: <mailman.336.1743352361.359.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Jing Luo <jing@jing.rocks>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH pve-manager] [multiarch] pvestatd: don't query
supported CPU flags if we are not x86_64
Content-Type: multipart/mixed; boundary="===============3010746121033640444=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============3010746121033640444==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <jing@jing.rocks>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 5CCECCC813
for <pve-devel@lists.proxmox.com>; Sun, 30 Mar 2025 18:32:40 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E82F436384
for <pve-devel@lists.proxmox.com>; Sun, 30 Mar 2025 18:30:30 +0200 (CEST)
Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Sun, 30 Mar 2025 18:30:26 +0200 (CEST)
Received: from mail-gw3.jing.rocks (localhost [127.0.0.1])
by mail-gw3.jing.rocks (Proxmox) with ESMTP id 4F52E1F833
for <pve-devel@lists.proxmox.com>; Mon, 31 Mar 2025 01:30:16 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc
:cc:content-transfer-encoding:date:from:from:message-id
:mime-version:reply-to:subject:subject:to:to; s=mail-gw; bh=FeGx
Amd24frElS52YdWxwZ1QSSKNU+UlpDRgUneBc6k=; b=FB7n/hbxora2B9qtIjky
6DHlUoSkgohYqE66Nuyvi/BWWnnPAx0jPmvYiKj83/m+InDl1uC7rVfZlcP8ujDS
B5uSzeihjXluk9Nna7Ou3jfJ+fO+pGx/8WDCKgomPVDdy4/i4atgRv9BEkWILJ0q
ra/eC5DSKRJmPh/5AZjaZZMW4/3cKOsZt6e8NUDySCgAP+ICuN8eq2yd+29A8Pil
/CKRj1MjKYVGPYXoNiRT0ow04Eg/up9RsSDYtW7iK5nwm0bLYfd2kSzBq76nGulg
IiAaaqGAi6qazvPXETUbEuZsq1k/GhbY2LxX0tLFKhbFDytSwiiLzDj+MV1wHH//
vw==
Received: from mail.jing.rocks (mail.jing.rocks [IPv6:240b:10:f00:1b00::222])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mail-gw3.jing.rocks (Proxmox) with ESMTPS id C362E1F82C
for <pve-devel@lists.proxmox.com>; Mon, 31 Mar 2025 01:30:12 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks;
s=default; t=1743352212;
bh=ApVguQcTorYm8BM/+S+CSEEs97ovZ7yGoS4GybmXt5M=;
h=From:To:Cc:Subject:Date:From;
b=jmwLy1YKdTUbBH5xDh3NTBDDT/3qtrLeTmZKRCd9S55FcN3Y28hFA723HCXYEqJ4/
Qm0TWCCbwgdL+mtUwKW3PrcIwdoyY9vW30CxU3KagZIm7YYEm8KBdphgRjyaRRGz9v
TxrOC4RUyFBLBgsE1zo+1RxPhCM4wJu30h+UpnSKXXvb5B1XFLBPt8nLf3hwAVoElf
AP7NOPCd210X/835tgWVCEYQHdNg3/8nfi1uGbEMjNnOSMbTVBA6KY1Sj0ognFnZyr
h5bjcppTaRmA2X0XgeBC3zjRA0rNsL7TDhPZig5QluZ4XFzwj06xHH15Ini23YjZYY
vNuK4LuDMBDbg==
Received: from debbuild12.jing.rocks (unknown [IPv6:240b:10:f00:1b00::1205])
(Authenticated sender: jing@jing.rocks)
by mail.jing.rocks (Postfix) with ESMTPSA id A93E74E5F4;
Mon, 31 Mar 2025 01:30:12 +0900 (JST)
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-manager] [multiarch] pvestatd: don't query supported CPU flags if we are not x86_64
Date: Mon, 31 Mar 2025 01:28:49 +0900
Message-ID: <20250330163006.3949380-1-jing@jing.rocks>
X-Mailer: git-send-email 2.49.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
KAM_OTHER_BAD_TLD 0.75 Other untrustworthy TLDs
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvestatd.pm,jing.rocks,qemuserver.pm]
Only qemu-system-x86_64 will output a list of cpuflags, so let's only
do it on x86_64. For now, we don't consider the case of non-x86, and
it silences warnings on non-x86:
(e.g. on aarch64, riscv64)
Mar 31 00:20:24 debian1 pvestatd[58071]: warning: failed querying supported tcg flags: QEMU flag querying VM exited with code -1 at /usr/share/perl5/PVE/QemuServer.pm line 3312.
Mar 31 00:20:24 debian1 pvestatd[58071]: CPU flag detection failed, will try again after delay
(e.g. on powerpc64, powerpc64le)
Mar 31 00:24:25 debian2 pvestatd[58071]: VM -1 qmp command failed - VM -1 qmp command 'query-cpu-model-expansion' failed - The command query-cpu-model-expansion has not been found
Mar 31 00:24:25 debian2 pvestatd[58071]: warning: failed querying supported tcg flags: VM -1 qmp command 'query-cpu-model-expansion' failed - The command query-cpu-model-expansion has not been found
Mar 31 00:24:25 debian2 pvestatd[58071]: CPU flag detection failed, will try again after delay
Signed-off-by: Jing Luo <jing@jing.rocks>
---
PVE/Service/pvestatd.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 4911d4ac..f5580aec 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -9,7 +9,7 @@ use PVE::Daemon;
use JSON;
use Time::HiRes qw (gettimeofday);
-use PVE::Tools qw(dir_glob_foreach file_read_firstline);
+use PVE::Tools qw(dir_glob_foreach file_read_firstline get_host_arch);
use PVE::ProcFSTools;
use PVE::CpuSet;
use Filesys::Df;
@@ -156,7 +156,9 @@ sub update_node_status {
my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
my $maxcpu = $cpuinfo->{cpus};
- update_supported_cpuflags();
+ # only qemu-system-x86_64 can output cpuflags with "-cpu help"
+ my $arch = PVE::Tools::get_host_arch();
+ update_supported_cpuflags() if $arch eq "x86_64";
my $netdev = PVE::ProcFSTools::read_proc_net_dev();
# traffic from/to physical interface cards
--
2.49.0
--===============3010746121033640444==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============3010746121033640444==--