From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 004561FF185
for <inbox@lore.proxmox.com>; Mon, 9 Jun 2025 09:32:35 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1D825375E3;
Mon, 9 Jun 2025 09:32:58 +0200 (CEST)
To: pve-devel@lists.proxmox.com
Date: Mon, 9 Jun 2025 10:32:09 +0300
In-Reply-To: <20250609073214.7880-1-denis.kanchev@storpool.com>
References: <20250609073214.7880-1-denis.kanchev@storpool.com>
MIME-Version: 1.0
Message-ID: <mailman.304.1749454376.395.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Demayl via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Demayl <denis.kanchev@storpool.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH atomic snapshot 1/4] ui: snapshot: add atomic
option
Content-Type: multipart/mixed; boundary="===============2478772363713946106=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============2478772363713946106==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <denis.kanchev@storpool.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 751CECCD98
for <pve-devel@lists.proxmox.com>; Mon, 9 Jun 2025 09:32:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4A41C37446
for <pve-devel@lists.proxmox.com>; Mon, 9 Jun 2025 09:32:26 +0200 (CEST)
Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 9 Jun 2025 09:32:25 +0200 (CEST)
Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-442f4a3a4d6so21531115e9.0
for <pve-devel@lists.proxmox.com>; Mon, 09 Jun 2025 00:32:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=storpool.com; s=google; t=1749454339; x=1750059139; darn=lists.proxmox.com;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=vSXhXmtcDU6phq2IgIJ+dnsM15aQ1GkxlHYeZStRM4E=;
b=F+mvVkYXH0NOZjK/N8eGiqRjvTz529rR3FIfwMjLLi/kcpexH2/mz44G32dlLe9sbG
IDo79aRDaAYm+7Bg8MYwHe4Dzx+4U+5/kGFtP8Ha9X3o3dvzuqCi2+LXwaGXGQ2EO+Nh
jjQcAZbcoa7geZ/dB+eEE8Y5pWRsVPHMbvmO5szKIkl+BjSdDN1N88nTA/G/YK8NCsZR
TiH2KQqYkbPMM2sEMSFWkpwalqhB4aP+m74FlhH6QoihzT5pVAf5Awrx4hkmj9RNsc+D
AbK9tpnAUi3LCClc6V+Mh9NG/CEW23DojtfYwpbGalT4zH5g1XAj1ia/HSS8C8MUc33M
1vIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749454339; x=1750059139;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=vSXhXmtcDU6phq2IgIJ+dnsM15aQ1GkxlHYeZStRM4E=;
b=eesDM7LUaKs3S4gfG8koACiItOZwDTtVrRTXb98qxYHmXrsG4kM0220GTyfXlOUWEj
YUYSKZ0wN2vFJnGCvh/yjY0dLQcNTjQOTaeB9R9TaQsPdLRaxn/mBmpvymyicEu0+5xU
NITCx3X/vSjFvnzICPgSASYQTY3EIbNiiZLlLJhJdbquHKIPwXMheBt47/xxlomoG3zI
KBb1f4WzD8djmXx5Jy+K4oNL1/x0U+vomhMM4dZycxPfCbLMCWp5ByhtbeyIAN5HnoIO
T5JY61O/V7abDCxyhg9mD6VHtHKskUXlnj4sFiDxao9KvDmqGz22b/CV6XHz0sd9c0jr
L4EA==
X-Gm-Message-State: AOJu0Yyk7af9D0AQi+6AXwuzZex7ZUtb8pm9VIA10VVnY/0/fddc0FVy
62neC9qJ+ewDBYixErrr3BfbHTX+tr2XWjMauyWq7rT6qX+uLyfcYjvQMi2kgs3DAyKUAALV1Rb
NZGIs4JU=
X-Gm-Gg: ASbGnctWt4xydOW9XSXoCFZ9fXfNKsK0RvgGHV7grfJJBGCx0XAh5y1xa5fOVOAeu22
qPVuW82HCxmIIwqOCZwuDlcIGZHBKJbFHBV81LhGNDuexe0PDdpowv1MfRMY5i76KqODLa6v/km
9k3M8gstYCaWp2ndO5PrY3s4BSGl/g8dZlyPvZeztlDOWVW2O9YIWQCu/uuXCRx18aLwH1/6CNG
9Lbk/6G7fDbEJbTsbBzaXOqvutoabjPVfSLC71ZFqvR9PHHA1se8Bk7hwU39hqg1UFJfqnLQemR
M+e5R3TiMbPrz53dZzkdccTPcV8Ie7UCzxp26oMsc7UMx07JZdbAqqxbU0ZtQs+JMoWIJoQIKni
XL/n2e8IzJoHFO3wYs3MM
X-Google-Smtp-Source: AGHT+IHWf/a+RgpiKoomSch3FXotgIHt73ZUfOYVf37o1qclIHwP/7aOaqhIiF4qMEUmcaEuLsxeJg==
X-Received: by 2002:a05:600c:8508:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-45201506d2cmr112302525e9.5.1749454338635;
Mon, 09 Jun 2025 00:32:18 -0700 (PDT)
Received: from dennis.. (79-100-232-190.ip.btc-net.bg. [79.100.232.190])
by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521370961csm102916165e9.22.2025.06.09.00.32.17
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 09 Jun 2025 00:32:18 -0700 (PDT)
From: Demayl <denis.kanchev@storpool.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH atomic snapshot 1/4] ui: snapshot: add atomic option
Date: Mon, 9 Jun 2025 10:32:09 +0300
Message-ID: <20250609073214.7880-2-denis.kanchev@storpool.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20250609073214.7880-1-denis.kanchev@storpool.com>
References: <20250609073214.7880-1-denis.kanchev@storpool.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.000 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storpool.com]
Signed-off-by: Demayl <denis.kanchev@storpool.com>
---
www/manager6/window/Snapshot.js | 43 +++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
index 93ab61ec..902258b2 100644
--- a/www/manager6/window/Snapshot.js
+++ b/www/manager6/window/Snapshot.js
@@ -7,10 +7,14 @@ Ext.define('PVE.window.Snapshot', {
isCreate: undefined,
running: false,
guestAgentEnabled: false,
+ atomicPossible: false,
+ atomicPreferred: false,
},
formulas: {
runningWithoutGuestAgent: (get) => get('type') === 'qemu' && get('running') && !get('guestAgentEnabled'),
shouldWarnAboutFS: (get) => get('isCreate') && get('runningWithoutGuestAgent') && get('!vmstate.checked'),
+ atomicDisabled: (get) => !get('atomicPossible'),
+ typeCheck: (get) => get('atomicPreferred') && get('atomicPossible') ? 'atomic' : 'sequential' ,
},
},
@@ -55,6 +59,15 @@ Ext.define('PVE.window.Snapshot', {
vm.set('guestAgentEnabled', !!PVE.Parser.parseBoolean(enabled.enabled));
},
});
+ Proxmox.Utils.API2Request({
+ url: `/nodes/${me.nodename}/${me.type}/${me.vmid}/status/current`,
+ method: 'GET',
+ success: function(response, options) {
+ let snap = response.result.data.snapshots;
+ vm.set('atomicPossible', !!PVE.Parser.parseBoolean(snap.atomic_possible.toString()));
+ vm.set('atomicPreferred', !!PVE.Parser.parseBoolean(snap.atomic_preferred.toString()));
+ },
+ });
}
me.items = [
@@ -85,6 +98,36 @@ Ext.define('PVE.window.Snapshot', {
checked: 1,
fieldLabel: gettext('Include RAM'),
},
+ {
+ xtype: 'radiogroup',
+ fieldLabel: gettext('Type'),
+ vertical: true,
+ hidden: !me.isCreate,
+ columns: 1,
+ reference: 'atomic',
+ items: [
+ {
+ xtype: 'radiofield',
+ boxLabel: gettext('Sequential'),
+ name: 'type',
+ flex: 1,
+ inputValue: 'sequential',
+ bind: { value: '{typeCheck}' }
+ },
+ {
+ xtype: 'radiofield',
+ boxLabel: gettext('Atomic'),
+ name: 'type',
+ flex: 1,
+ inputValue: 'atomic',
+ disabled: true,
+ bind: {
+ value: '{typeCheck}',
+ disabled: '{atomicDisabled}',
+ }
+ }
+ ]
+ },
{
xtype: 'textareafield',
grow: true,
--
2.43.0
--===============2478772363713946106==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============2478772363713946106==--