From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 129921FF16E
	for <inbox@lore.proxmox.com>; Mon, 20 Jan 2025 15:29:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 375C61CA26;
	Mon, 20 Jan 2025 15:29:50 +0100 (CET)
Date: Mon, 20 Jan 2025 15:29:39 +0100
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
 "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
 "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
References: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com>
 <mailman.210.1734340371.332.pve-devel@lists.proxmox.com>
 <570013533.830.1736423850641@webmail.proxmox.com>
 <mailman.172.1736428820.441.pve-devel@lists.proxmox.com>
 <3307ec388a763510ec78f97ed9f0de00c87d54b5.camel@groupe-cyllene.com>
In-Reply-To: <3307ec388a763510ec78f97ed9f0de00c87d54b5.camel@groupe-cyllene.com>
MIME-Version: 1.0
Message-ID: <mailman.24.1737383389.336.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Fabio Fantoni via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Fabio Fantoni <fabio.fantoni@m2r.biz>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH v3 qemu-server 11/11] qcow2: add external
 snapshot support
Content-Type: multipart/mixed; boundary="===============0087134748412145387=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============0087134748412145387==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <fabio.fantoni@m2r.biz>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id A24C5C09A1
	for <pve-devel@lists.proxmox.com>; Mon, 20 Jan 2025 15:29:48 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8590F1C9DC
	for <pve-devel@lists.proxmox.com>; Mon, 20 Jan 2025 15:29:48 +0100 (CET)
Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Mon, 20 Jan 2025 15:29:47 +0100 (CET)
Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5d3e9a88793so7802815a12.1
        for <pve-devel@lists.proxmox.com>; Mon, 20 Jan 2025 06:29:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=m2r-biz.20230601.gappssmtp.com; s=20230601; t=1737383381; x=1737988181; darn=lists.proxmox.com;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:to:subject:user-agent:mime-version:date:message-id:from
         :to:cc:subject:date:message-id:reply-to;
        bh=dqmstiBKQYSno9wylR+r6ft6mOlFYNlesqoz9YSJi8Q=;
        b=iduguPjPr+oXFtf65DfpDm0h1eJCZTXit7NrBgsdOnqGTbE4Pk7hHDDuce7iL/yYj/
         1zNCMZF8t+44oefzSumy7VX2HjWdqXbIIcB00BzhyeZWYUxGVaeNMohqSN5GbtQioHJH
         q1RY/UWNv0SPiqJIGa0oSIeQMXQhVtxADOWHuE6V5hPGwoX/jBYeaS++H5h37fdhQ9JL
         7RGgObAgziLjUlfe/iZ2khJLUS1z7+u2tE2eClDoZai7J7IXST3SvxbL0UjbOvMzm1QM
         f2+uZV8uMNL6ktlLaKDSEKxEk7siTvgzhiwT4ZyrpDlFywYiI1SuGm3Ai9+FIBxARJ9p
         poSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1737383381; x=1737988181;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:to:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=dqmstiBKQYSno9wylR+r6ft6mOlFYNlesqoz9YSJi8Q=;
        b=Lc8cWpqAyFhIib9U0JdXrP6GJfZcOGRNQcY5qrSEY6Zz8wfdhXEODn6UGXJC+OX0tJ
         UOlUUXvB7lX5tX38HpXmFH2NXLXWbvQSXxDrljoZys0Uz5eZ5hbKZbzoqtHqnppRkrd4
         LeIOK8mLpDRemAavbFw6qKyjPAs/7Cai4tVFiT2NdMU4fACPUoet0Yb9EAZVVDTe8XzP
         IVXlaC41NQFZtBhjFBFh9FqDMLj5Ipb3OlOeMeJui3hWW4JjcHyeVqzdoIMpLt77GAoH
         OthVy2j+xkdTVSD2QbldnEoUWiN0TbRu/93AZW282HtiOulpqDPLPxmPtLoOnmpfCN1c
         WLYA==
X-Forwarded-Encrypted: i=1; AJvYcCXgj7gR2wSWbXKEmjJaj7g7m1oUEfrh6reZs0qYYa6ixCwYATGYULAfLkIxfH/OgeeO/rfgfVQl/Pk=@lists.proxmox.com
X-Gm-Message-State: AOJu0Yw3ZY4MJ97f1Z0cyIuTxC0fdGqIh0FE7XcXNJOXZNNysunkXFLf
	IyYSd27+Hj9YJqdTMo46ym2bPY6yeo/xuCe3vs9vbLhHUNHxSwG6kLgipHa0uRk=
X-Gm-Gg: ASbGncup81S28Y6phe77cVqKhi3QhkszKP/MGPJlx12uIzntX1aPINmEeZN6gZWF2ir
	N8y9GxKqA45mxw2l/vWNsHVIXMVd+xbC77+04JX20ZoYhLpviarJtMQW7ku12s+BtBX/LQEjxaX
	6aghfaUTRdmM6rMPCnr4tEWFZ45TsRkj99cspTpqANw8BKcOCfouriUwtlWrqXlzx5x1gs5aynU
	MICMxi7p5Gf6DShcDrbeYuN5QNR1KJAK6tYb6YybeXLZL31pvRuvdj8dj9aRn65KVA7AXMv9zO+
	mDrVY95dZNL/KCoMgbbhOUp754LxirVU1XWK+dqpXnzBol2KKLLestRaGA==
X-Google-Smtp-Source: AGHT+IFc0jVD3aAC2rOfh4gJAfpcRwT8WPwKRJxY8v9+cbAyqNpI9t7+j5E5tMXPSEW4Ynfl2/xDYw==
X-Received: by 2002:a17:907:7291:b0:aaf:3f57:9d2e with SMTP id a640c23a62f3a-ab38ad88887mr1244661666b.0.1737383381220;
        Mon, 20 Jan 2025 06:29:41 -0800 (PST)
Received: from [192.168.178.27] (host-79-18-78-119.retail.telecomitalia.it. [79.18.78.119])
        by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ab384ce0529sm617267166b.43.2025.01.20.06.29.40
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 20 Jan 2025 06:29:40 -0800 (PST)
Message-ID: <6bdfe757-ae04-42e1-b197-c9ddb873e353@m2r.biz>
Date: Mon, 20 Jan 2025 15:29:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [pve-devel] [PATCH v3 qemu-server 11/11] qcow2: add external
 snapshot support
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
 "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
 "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
References: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com>
 <mailman.210.1734340371.332.pve-devel@lists.proxmox.com>
 <570013533.830.1736423850641@webmail.proxmox.com>
 <mailman.172.1736428820.441.pve-devel@lists.proxmox.com>
 <3307ec388a763510ec78f97ed9f0de00c87d54b5.camel@groupe-cyllene.com>
Content-Language: it
From: Fabio Fantoni <fabio.fantoni@m2r.biz>
In-Reply-To: <3307ec388a763510ec78f97ed9f0de00c87d54b5.camel@groupe-cyllene.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Antivirus: Avast (VPS 250119-6, 19/1/2025), Outbound message
X-Antivirus-Status: Clean
X-SPAM-LEVEL: Spam detection results:  0
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DMARC_PASS               -0.1 DMARC pass policy
	JMQ_SPF_NEUTRAL           0.5 SPF set to ?all
	KAM_INFOUSMEBIZ          0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
	RCVD_IN_DNSWL_NONE     -0.0001 Sender listed at https://www.dnswl.org/, no trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record

Il 20/01/2025 14:44, DERUMIER, Alexandre ha scritto:
> Hi Fabio !
>
>>> In this implementation I don't see the possibility of using them on
>>> raw
>>> disks (on files) from a fast look, or am I wrong? If so, why? I think
>>> the main use would be in cases like that where you don't have
>>> snapshot
>> <support by default
> Ah, we have discussed about it with Fabian. the V1/v2 had raw support,
> but I have removed it from v3 because it's simplify a lot the code,
> and from my test, I don't see anymore too much difference between qcow2
> && raw. (maybe 10% diff max)
>
> Note that you can preallocated 100% the base qcow2 image if you want.
> (or only metadatas, that's the defaut)
>
>
> I'm going to do more extensive benchmark, but qcow2 have improved a lot
> since last years (with sub-allocation clusters), so it should be too
> far from a cow filesystem like zfs,btrfs. (sure, they are still
> overhead vs a simple raw).
>
>
>
Thanks for your reply, I don't remember exactly when my tests date back 
(for external snapshot), it's been several years now, and I had done 
them on the default versions of Debian 10, I used, and still use on most 
servers, with libvirt.We had all the servers with enterprise hdd in 
raid1 or raid10 and the difference in performance between pre-allocated 
raw and qcow2, even just used with external snapshots was clearly 
visible (also without benchmark). I haven't had enough time for a few 
years to keep myself well informed about the virtualization part and do 
significant testing, I've recently started investing a lot of time in 
learning and testing again with proxmox, even though I didn't have many 
other things to manage.

in recent years we use only or almost only ssd and nvme disks (on new or 
improved servers) and it is not necessary to have them pre-allocated, 
the latter are basically not pre-allocated and the proxmox ones (latest) 
with lvm-thin, however we are upgrading some servers (and we will do 
more) to proxmox keeping the existing storage on pre-allocated raw files 
and it would be useful for example to have snapshot support also in 
these cases, unfortunately since it is not based on libvirt I cannot do 
it even manually (in a fairly fast and safe way that I had tested and 
documented) from the command line and I do not know if it would be 
possible with some workarounds and more operations to force it even if 
not implemented in proxmox.

I use qcow2 by default on my PCs (with libvirt though) for some test vms 
where I use snapshots quite a bit, but internal and from virt-manager, 
using on ssd/nvme and usually a single active vm I don't notice any 
particular performance problems, in truth I've never done any tests 
regarding performance on my workstations in this regard

for this implementation instead I think it is important to measure and 
document in order to give enough information to users to make good 
choices (and seems you want do it)

out of curiosity, besides the obvious cases where external snapshots 
would be useful, i.e. on raw files and on lvm (not lvm-thin), what other 
cases would be useful given that they already have snapshot support 
(qcow2 with the internal one, zfs, btrfs, lvm-thin etc)?

not having it on raw files I think would take away a lot of its 
usefulness, but I could be wrong if there are uses I can't imagine, 
maybe make something more possible with replicas and migrations? (I 
haven't looked into it enough)


-- 
Questa email =C3=A8 stata esaminata alla ricerca di virus dal software anti=
virus Avast.
www.avast.com


--===============0087134748412145387==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============0087134748412145387==--