From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A9BAC1FF15F for ; Mon, 16 Dec 2024 10:13:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4AA6C6FF9; Mon, 16 Dec 2024 10:12:51 +0100 (CET) To: pve-devel@lists.proxmox.com Date: Mon, 16 Dec 2024 10:12:28 +0100 In-Reply-To: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com> References: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH v3 qemu-server 10/11] blockdev: add backing_chain support Content-Type: multipart/mixed; boundary="===============2409028869669876032==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============2409028869669876032== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 86B8EC30A1 for ; Mon, 16 Dec 2024 10:12:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 70EC06EA7 for ; Mon, 16 Dec 2024 10:12:47 +0100 (CET) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 16 Dec 2024 10:12:45 +0100 (CET) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 52501860F13; Mon, 16 Dec 2024 10:12:32 +0100 (CET) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 936251084C68; Mon, 16 Dec 2024 10:12:31 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH v3 qemu-server 10/11] blockdev: add backing_chain support Date: Mon, 16 Dec 2024 10:12:28 +0100 Message-Id: <20241216091229.3142660-15-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com> References: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record We need to define name-nodes for all backing chain images, to be able to live rename them with blockdev-reopen For linked clone, we don't need to definebase image(s) chain. They are auto added with #block nodename. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index dc12b38f..3a3feadf 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1618,6 +1618,38 @@ sub generate_throttle_group { return $throttle_group; } +sub generate_backing_blockdev { + my ($storecfg, $snapshots, $deviceid, $drive, $id) = @_; + + my $snapshot = $snapshots->{$id}; + my $order = $snapshot->{order}; + my $parentid = $snapshot->{parent}; + my $snap_fmt_nodename = "fmt-$deviceid-$order"; + my $snap_file_nodename = "file-$deviceid-$order"; + + my $snap_file_blockdev = generate_file_blockdev($storecfg, $drive, $snap_file_nodename); + $snap_file_blockdev->{filename} = $snapshot->{file}; + my $snap_fmt_blockdev = generate_format_blockdev($storecfg, $drive, $snap_fmt_nodename, $snap_file_blockdev, 1); + $snap_fmt_blockdev->{backing} = generate_backing_blockdev($storecfg, $snapshots, $deviceid, $drive, $parentid) if $parentid; + return $snap_fmt_blockdev; +} + +sub generate_backing_chain_blockdev { + my ($storecfg, $deviceid, $drive) = @_; + + my $volid = $drive->{file}; + my $do_snapshots_with_qemu = do_snapshots_with_qemu($storecfg, $volid, $deviceid); + return if !$do_snapshots_with_qemu || $do_snapshots_with_qemu != 2; + + my $chain_blockdev = undef; + PVE::Storage::activate_volumes($storecfg, [$volid]); + #should we use qemu config to list snapshots ? + my $snapshots = PVE::Storage::volume_snapshot_info($storecfg, $volid); + my $parentid = $snapshots->{'current'}->{parent}; + $chain_blockdev = generate_backing_blockdev($storecfg, $snapshots, $deviceid, $drive, $parentid) if $parentid; + return $chain_blockdev; +} + sub generate_file_blockdev { my ($storecfg, $drive, $nodename) = @_; @@ -1816,6 +1848,8 @@ sub generate_drive_blockdev { my $blockdev_file = generate_file_blockdev($storecfg, $drive, $file_nodename); my $fmt_nodename = "fmt-drive-$drive_id"; my $blockdev_format = generate_format_blockdev($storecfg, $drive, $fmt_nodename, $blockdev_file, $force_readonly); + my $backing_chain = generate_backing_chain_blockdev($storecfg, "drive-$drive_id", $drive); + $blockdev_format->{backing} = $backing_chain if $backing_chain; my $blockdev_live_restore = undef; if ($live_restore_name) { -- 2.39.5 --===============2409028869669876032== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============2409028869669876032==--