From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 86AFE1FF165
for <inbox@lore.proxmox.com>; Wed, 26 Mar 2025 04:59:10 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 108A01C8BA;
Wed, 26 Mar 2025 04:59:04 +0100 (CET)
Date: Wed, 26 Mar 2025 16:51:23 +1300
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <mailman.62.1731030290.372.pve-devel@lists.proxmox.com>
<20241108014620.73352-1-severen.redwood@sitehost.co.nz>
<mailman.67.1731030447.372.pve-devel@lists.proxmox.com>
<1864670080.9140.1737980289994@webmail.proxmox.com>
<b8f26204-e6d2-40b6-8048-0f9883d65b4d@proxmox.com>
In-Reply-To: <b8f26204-e6d2-40b6-8048-0f9883d65b4d@proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.191.1742961543.359.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH cluster v4 1/2] cluster files: add
used_vmids.list
Content-Type: multipart/mixed; boundary="===============3024541869878541573=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============3024541869878541573==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <severen.redwood@sitehost.co.nz>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 32805CA7E1
for <pve-devel@lists.proxmox.com>; Wed, 26 Mar 2025 04:59:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1C9291C890
for <pve-devel@lists.proxmox.com>; Wed, 26 Mar 2025 04:59:03 +0100 (CET)
Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 26 Mar 2025 04:59:01 +0100 (CET)
Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1])
by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id 9487C18096E;
Wed, 26 Mar 2025 16:51:30 +1300 (NZDT)
X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz
X-Spam-Flag: NO
X-Spam-Score: -3.449
X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5
tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55,
URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mx3.ext.sitehost.co.nz ([127.0.0.1])
by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id q6TlOo3UL2Tq; Wed, 26 Mar 2025 16:51:23 +1300 (NZDT)
Received: from [192.168.99.182] (oep.nct.sitehost.co.nz [120.138.23.30])
by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id A6EE2180BFC;
Wed, 26 Mar 2025 16:51:23 +1300 (NZDT)
Message-ID: <fd441572-6c7c-4b62-bdef-0d738ac699fb@sitehost.co.nz>
Date: Wed, 26 Mar 2025 16:51:23 +1300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [pve-devel] [PATCH cluster v4 1/2] cluster files: add
used_vmids.list
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <mailman.62.1731030290.372.pve-devel@lists.proxmox.com>
<20241108014620.73352-1-severen.redwood@sitehost.co.nz>
<mailman.67.1731030447.372.pve-devel@lists.proxmox.com>
<1864670080.9140.1737980289994@webmail.proxmox.com>
<b8f26204-e6d2-40b6-8048-0f9883d65b4d@proxmox.com>
Content-Language: en-NZ
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>,
=?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
From: Severen Redwood <severen.redwood@sitehost.co.nz>
In-Reply-To: <b8f26204-e6d2-40b6-8048-0f9883d65b4d@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.047 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_PASS -0.1 DMARC pass policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_PASS -0.001 SPF: HELO matches SPF record
SPF_PASS -0.001 SPF: sender matches SPF record
On 29/01/2025 03:57, Thomas Lamprecht wrote:
> Am 27.01.25 um 13:18 schrieb Fabian Grünbichler:
>>> Severen Redwood via pve-devel <pve-devel@lists.proxmox.com> hat am 08.11.2024 02:46 CET geschrieben:
>>
>>> Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
>>> be used for recording previously used VM/CT IDs. This is required so
>>> that we can optionally ensure that such IDs are not suggested by the
>>> `/cluster/nextid` API endpoint.
>>
>> this is encroaching bikeshed-territory, but we don't currently use ".list" as an extension in /etc/pve (and I automatically have to think of APT repository files when seeing it ;)). I think a plain "used_vmids" or "used-vmids" would also work?
>>
>> maybe somebody else has an opinion or suggestion?
>
> I agree, and I would prefer kebab-case in any way, i.e.: used-vmids
No problem, I've changed it to `/etc/pve/used-ids` now. Slightly more generic than `used-vmids` since there are also container IDs.
> Besides that it mostly depends on if we want to re-use a common file for other
> such specific use cases around VMIDs like per-{user,group,pool} reservations
> (or allow-lists) of VMID ranges.
>
> One certainly does not need to implement that for landing this series, but
> might be worth use a slightly more structured format and generalized file
> name to allow easier extension in that direction without new files and
> only needing to look at a single file when allocating VMID.
> But this can also be adapted on applying, it should mostly affect parsing
> and serialization, and maybe those even not _that_ much.
I've not done this just yet since I'm not sure what sort of format you would prefer. Possibly some kind of section headers to separate out the different parts of the file? But maybe it's best to leave that for when the patches are applied.
--===============3024541869878541573==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============3024541869878541573==--