From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A85E21FF15E for ; Fri, 4 Oct 2024 07:10:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9348D8117; Fri, 4 Oct 2024 07:10:51 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Fri, 4 Oct 2024 18:07:41 +1300 In-Reply-To: <20241004050957.441759-1-severen.redwood@sitehost.co.nz> References: <20241004050957.441759-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood , Thomas Lamprecht X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH manager v2 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Content-Type: multipart/mixed; boundary="===============6672607790611000249==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============6672607790611000249== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 140B9C2851 for ; Fri, 4 Oct 2024 07:10:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F16F38096 for ; Fri, 4 Oct 2024 07:10:49 +0200 (CEST) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Oct 2024 07:10:49 +0200 (CEST) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id 15494180A2F; Fri, 4 Oct 2024 18:10:42 +1300 (NZDT) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.449 X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OxiezyQb-edF; Fri, 4 Oct 2024 18:10:38 +1300 (NZDT) Received: from yggdrasill.. (oep.air.sitehost.co.nz [120.138.16.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id CB1DB180B17; Fri, 4 Oct 2024 18:10:37 +1300 (NZDT) From: Severen Redwood To: pve-devel@lists.proxmox.com Cc: Thomas Lamprecht , Dietmar Maurer , Severen Redwood , Daniel Krambrock Subject: [PATCH manager v2 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Date: Fri, 4 Oct 2024 18:07:41 +1300 Message-ID: <20241004050957.441759-3-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241004050957.441759-1-severen.redwood@sitehost.co.nz> References: <20241004050957.441759-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.138 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Add a 'suggest unique VMIDs' row to the datacenter options page that allows choosing whether the `/cluster/nextid` API endpoint (and thereby any UI elements that suggest IDs) should avoid suggesting previously used IDs. This option defaults to off to ensure that this change in behaviour is opt in. Co-authored-by: Daniel Krambrock Signed-off-by: Severen Redwood --- www/manager6/dc/OptionView.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index b200fd12..feace344 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -339,6 +339,10 @@ Ext.define('PVE.dc.OptionView', { submitValue: true, }], }); + me.add_boolean_row('unique-next-id', gettext('Suggest unique VMIDs'), { + defaultValue: 0, + deleteDefaultValue: true, + }); me.rows['tag-style'] = { required: true, renderer: (value) => { -- 2.46.2 --===============6672607790611000249== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============6672607790611000249==--