From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CC1F41FF191 for ; Tue, 21 Oct 2025 16:01:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22F6331F; Tue, 21 Oct 2025 16:01:40 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Tue, 21 Oct 2025 16:00:54 +0200 In-Reply-To: <20251021140054.3916467-1-alexandre.derumier@groupe-cyllene.com> References: <20251021140054.3916467-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH v2 pve-storage 2/2] fix #6941 : lvmplugin : fix activation on secure delete Content-Type: multipart/mixed; boundary="===============1622090424902597207==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============1622090424902597207== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F05CDD2F2A for ; Tue, 21 Oct 2025 16:01:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C9C20C9 for ; Tue, 21 Oct 2025 16:01:07 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Oct 2025 16:01:03 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 44FFA862E4B; Tue, 21 Oct 2025 16:00:56 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 37174111777E; Tue, 21 Oct 2025 16:00:56 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH v2 pve-storage 2/2] fix #6941 : lvmplugin : fix activation on secure delete Date: Tue, 21 Oct 2025 16:00:54 +0200 Message-ID: <20251021140054.3916467-3-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251021140054.3916467-1-alexandre.derumier@groupe-cyllene.com> References: <20251021140054.3916467-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -1.709 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_QUAR 0.1 DMARC quarantine policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_QUARANTINE 4 DKIM has Failed or SPF has failed on the message and the domain has a DMARC quarantine policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm] It was lost in the lvm qcow2 patches Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 1c633a3..9716854 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -375,6 +375,17 @@ my sub free_lvm_volumes { my $lvmpath = "/dev/$vg/del-$name"; print "zero-out data on image $name ($lvmpath)\n"; + my $cmd_activate = ['/sbin/lvchange', '-aly', $lvmpath]; + run_command( + $cmd_activate, + errmsg => "can't activate LV '$lvmpath' to zero-out its data", + ); + $cmd_activate = ['/sbin/lvchange', '--refresh', $lvmpath]; + run_command( + $cmd_activate, + errmsg => "can't refresh LV '$lvmpath' to zero-out its data", + ); + $secure_delete_cmd->($lvmpath); $class->cluster_lock_storage( @@ -755,13 +766,6 @@ my sub alloc_snap_image { my sub free_snap_image { my ($class, $storeid, $scfg, $volname, $snap) = @_; - #activate only the snapshot volume - my $path = $class->path($scfg, $volname, $storeid, $snap); - my $cmd = ['/sbin/lvchange', '-aly', $path]; - run_command($cmd, errmsg => "can't activate LV '$path' to zero-out its data"); - $cmd = ['/sbin/lvchange', '--refresh', $path]; - run_command($cmd, errmsg => "can't refresh LV '$path' to zero-out its data"); - my $snap_volname = get_snap_name($class, $volname, $snap); return free_lvm_volumes($class, $scfg, $storeid, [$snap_volname]); } @@ -777,11 +781,7 @@ sub free_image { #activate volumes && snapshot volumes my $path = $class->path($scfg, $volname, $storeid); $path = "\@pve-$name" if $format && $format eq 'qcow2'; - my $cmd = ['/sbin/lvchange', '-aly', $path]; - run_command($cmd, errmsg => "can't activate LV '$path' to zero-out its data"); - $cmd = ['/sbin/lvchange', '--refresh', $path]; - run_command($cmd, errmsg => "can't refresh LV '$path' to zero-out its data"); - + $class->activate_volume($storeid, $scfg, $volname); my $snapshots = $class->volume_snapshot_info($scfg, $storeid, $volname); for my $snapid ( sort { $snapshots->{$a}->{order} <=> $snapshots->{$b}->{order} } -- 2.47.3 --===============1622090424902597207== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============1622090424902597207==--