From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0583F1FF16B for ; Mon, 30 Sep 2024 13:32:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DE9A1566D; Mon, 30 Sep 2024 13:32:38 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Mon, 30 Sep 2024 13:31:50 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH SERIES v2 pve-storage/qemu-server] add external qcow2 snapshot support Content-Type: multipart/mixed; boundary="===============2149617338650746979==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============2149617338650746979== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A6F16C1C2B for ; Mon, 30 Sep 2024 13:32:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 884E115393 for ; Mon, 30 Sep 2024 13:32:06 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 30 Sep 2024 13:32:04 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id DE6CE86AEC1; Mon, 30 Sep 2024 13:31:56 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 412E21020371; Mon, 30 Sep 2024 13:31:54 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH SERIES v2 pve-storage/qemu-server] add external qcow2 snapshot support Date: Mon, 30 Sep 2024 13:31:50 +0200 Message-Id: <20240930113153.2896648-1-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record This patch series implement qcow2 external snapshot support for files && lvm volumes The current internal qcow2 snapshots have a lot of performance problems. I have tested through nfs and also local filesystem https://lore.proxmox.com/pve-devel/6a44716a-88bc-4523-b210-d67031917d8f@proxmox.com/t/ I see that Fiona don't have same result than me, but I got something like 200~300iops vs 20000 iops with 4k randwrite when a snapshot exist. The result is even worst on a shared filesystem like ocfs2 or gfs2. (around 80 iops) I think (I'm not 100% sure) this is mostly because metadatas are not preallocated anymore with qcow2 internal snap. With external snapshot, I almost don't have any performance impact when a snapshot exist. Also other bugs are freeze/lock reported by users since years on snapshots delete on nfs https://forum.proxmox.com/threads/snapshot-removal-jams-the-vm.111648/ (The disk access seem to be frozen during all the delete duration) External qcow2 snapshots also allow snapshot of raw devices ,so 0 performance impact without snapshots. This also open doors for remote snapshot export-import for storage replication. This V2 introduce support for qcow2 external snapshot for lvm, extra lvm volume is created for each snapsphot and formated with qcow2. This is a lot more performant than lvm (non-thin/nomedata) snapshot, and allow to use it for shared lvm. (I have another patch series for thick lvm dynamic extend, but if we could have at minimum snapshot working, it could great :) I have tested: snasphot, snap rollback, snap delete, clone, move disk, rename disk, create_base. (online && offline) lxc is not yet supported, but I think we could look to implement the recent dm-qcow2 kernel block driver https://lore.kernel.org/lkml/164846619932.251310.3668540533992131988.stgit@pro/T/ storage.cfg example: dir: local2 path /var/liv/vz content snippets,vztmpl,backup,images,iso,rootdir snapext 1 lvmqcow2:test vgname test snapext 1 content images changelog v2: implement lvm with external qcow2 snapshots pve-storage: Alexandre Derumier (2): add external snasphot support add lvmqcow2 plugin: (lvm with external qcow2 snapshot) src/PVE/Storage.pm | 2 + src/PVE/Storage/DirPlugin.pm | 1 + src/PVE/Storage/LvmQcow2Plugin.pm | 460 ++++++++++++++++++++++++++++++ src/PVE/Storage/Makefile | 3 +- src/PVE/Storage/Plugin.pm | 225 +++++++++++++-- 5 files changed, 665 insertions(+), 26 deletions(-) create mode 100644 src/PVE/Storage/LvmQcow2Plugin.pm qemu-server: Alexandre Derumier (1): implement external snapshot PVE/QemuServer.pm | 108 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 95 insertions(+), 13 deletions(-) -- 2.39.2 --===============2149617338650746979== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============2149617338650746979==--