From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6A15F1FF16B for ; Tue, 15 Jul 2025 07:27:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 23ACE33431; Tue, 15 Jul 2025 07:27:26 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Tue, 15 Jul 2025 07:26:39 +0200 In-Reply-To: <20250715052643.1182073-1-alexandre.derumier@groupe-cyllene.com> References: <20250715052643.1182073-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH FOLLOW-UP storage 06/10] plugin|lvmplugin: don't allow volume rename if external snapshots exist. Content-Type: multipart/mixed; boundary="===============5262987176771857924==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============5262987176771857924== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0F9F4D97C6 for ; Tue, 15 Jul 2025 07:27:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4C0D3299B for ; Tue, 15 Jul 2025 07:26:54 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [185.151.190.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 15 Jul 2025 07:26:54 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id D6394862E4B; Tue, 15 Jul 2025 07:26:44 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id D39A711F6B09; Tue, 15 Jul 2025 07:26:44 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH FOLLOW-UP storage 06/10] plugin|lvmplugin: don't allow volume rename if external snapshots exist. Date: Tue, 15 Jul 2025 07:26:39 +0200 Message-Id: <20250715052643.1182073-6-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250715052643.1182073-1-alexandre.derumier@groupe-cyllene.com> References: <20250715052643.1182073-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Just to safe, as this is already check higher in the stack. Technically, it's possible to implement snapshot file renaming, and update backing_file info with "qemu-img rebase -u". Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 6 ++++++ src/PVE/Storage/Plugin.pm | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 9aadbc2..8a61bc5 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -1233,6 +1233,12 @@ sub rename_volume { my ( undef, $source_image, $source_vmid, $base_name, $base_vmid, undef, $format, ) = $class->parse_volname($source_volname); + + if ($format eq 'qcow2') { + my $snapshots = $class->volume_snapshot_info($scfg, $storeid, $source_volname); + die "we can't rename volume if external snapshot exists" if $snapshots->{current}->{parent}; + } + $target_volname = $class->find_free_diskname($storeid, $scfg, $target_vmid, $format) if !$target_volname; diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 06d258e..8ea62e4 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2175,6 +2175,11 @@ sub rename_volume { die "not implemented in storage plugin '$class'\n" if $class->can('api') && $class->api() < 10; die "no path found\n" if !$scfg->{path}; + if ($scfg->{'external-snapshots'}) { + my $snapshots = $class->volume_snapshot_info($scfg, $storeid, $source_volname); + die "we can't rename volume if external snapshot exists" if $snapshots->{current}->{parent}; + } + my ( undef, $source_image, $source_vmid, $base_name, $base_vmid, undef, $format, ) = $class->parse_volname($source_volname); -- 2.39.5 --===============5262987176771857924== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============5262987176771857924==--