From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 399B21FF16B for ; Mon, 30 Sep 2024 02:24:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F51CDC0B; Mon, 30 Sep 2024 02:24:54 +0200 (CEST) Date: Mon, 30 Sep 2024 13:24:36 +1300 To: "Thomas Lamprecht" , References: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> <20240926135516.117065-4-severen.redwood@sitehost.co.nz> In-Reply-To: MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed Content-Type: multipart/mixed; boundary="===============1819324544612190345==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============1819324544612190345== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3C6D6C1B00 for ; Mon, 30 Sep 2024 02:24:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19408DB62 for ; Mon, 30 Sep 2024 02:24:53 +0200 (CEST) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 30 Sep 2024 02:24:51 +0200 (CEST) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id E1D8518058A; Mon, 30 Sep 2024 13:24:41 +1300 (NZDT) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.45 X-Spam-Status: No, score=-3.45 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ApIzVlN5Qv-Q; Mon, 30 Sep 2024 13:24:38 +1300 (NZDT) Received: from localhost (oep.air.sitehost.co.nz [120.138.16.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id 5AB79180580; Mon, 30 Sep 2024 13:24:36 +1300 (NZDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Sep 2024 13:24:36 +1300 Message-Id: Subject: Re: [PATCH container] api: record CT ID as used after a container is destroyed From: "Severen Redwood" To: "Thomas Lamprecht" , X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> <20240926135516.117065-4-severen.redwood@sitehost.co.nz> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.199 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record On Fri Sep 27, 2024 at 5:48 AM NZST, Thomas Lamprecht wrote: > at this point the CT is not yet destroyed, only the worker that tries to = destroy > it is started, destruction can still fail. > > It'd be better to place it inside the $realcmd, or even the $code, ideall= y > before the actual unlink of the vmid.conf file, as after that happens the > ID gets free again from the POV of the pmxcfs and thus pve-cluster's VMID > list that is used by the next-id call. Thanks for pointing that out! Upon review, that is definitely the wrong place to add the CT ID to the list. I'll move the call to `PVE::UsedVmidList::add_vmid` to sit just before the call to `PVE::LXC::Config->destroy_config` in the `$code` subroutine instead, which I think is in the vein of your suggestion. --===============1819324544612190345== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============1819324544612190345==--