From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B6FDF1FF176
for <inbox@lore.proxmox.com>; Fri, 7 Feb 2025 13:34:17 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 10876A4CD;
Fri, 7 Feb 2025 13:34:15 +0100 (CET)
Date: Fri, 7 Feb 2025 13:34:04 +0100
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <mailman.122.1738918965.293.pve-devel@lists.proxmox.com>
<56159490.3085.1738919922263@webmail.proxmox.com>
In-Reply-To: <56159490.3085.1738919922263@webmail.proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.127.1738931654.293.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Roland Kammerer <roland.kammerer@linbit.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Content-Type: multipart/mixed; boundary="===============0093945683035962146=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============0093945683035962146==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <roland.kammerer@linbit.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 48CF9CB32E
for <pve-devel@lists.proxmox.com>; Fri, 7 Feb 2025 13:34:14 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 25F0BA4A0
for <pve-devel@lists.proxmox.com>; Fri, 7 Feb 2025 13:34:14 +0100 (CET)
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Fri, 7 Feb 2025 13:34:13 +0100 (CET)
Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-53f757134cdso2116843e87.2
for <pve-devel@lists.proxmox.com>; Fri, 07 Feb 2025 04:34:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linbit-com.20230601.gappssmtp.com; s=20230601; t=1738931646; x=1739536446; darn=lists.proxmox.com;
h=user-agent:in-reply-to:content-transfer-encoding
:content-disposition:mime-version:references:message-id:subject:cc
:to:from:date:from:to:cc:subject:date:message-id:reply-to;
bh=kLn+ICB2LikE6g9mb9oTSaDSPjp1us4LrYLfHxVU/Yw=;
b=NDTzrByUnXiQ1HknVkx2Zu3dR0a4qEqGO43fe+NAlsX/JseTiUvPt/yUrg/S8lSnG5
iXydmRfSlYGgUopwPO11mzuiRY35SyIoFVS5usGn9zgEgF6uJf8Y+3KGwoAzYS7b9Xpm
hXTSquYEZqwH0k1+9KAIRmaGcOqDgYemkp+5PUeZuFwjI+WKBvhG4J+u9ooRuK49ftpY
keB5lKZZDxalCEzXSJXiFSFwMSHE/fqqHDNt1gw29J7/5hd67FTff81EHzsKQe30VQhL
ltQpde8D+SMOup/CoJoMghDorhNvJqq3eWmkAWZTD7BW+t1pwOUJpFO0czaCvyMG/xNK
tBcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738931646; x=1739536446;
h=user-agent:in-reply-to:content-transfer-encoding
:content-disposition:mime-version:references:message-id:subject:cc
:to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=kLn+ICB2LikE6g9mb9oTSaDSPjp1us4LrYLfHxVU/Yw=;
b=dWJHUOGFlusEi72tvsFcU4v0v+WBuLl+5YzsgaoOfEVN7pfanXph89bheRjOmYKXSP
cnjkm2uU25INv9SNGRYW/Ing6enL+PsoYAoLks40MVPao/lLh3alnp0h91V16jZ/suWT
sX2OzJaIRENfBd7LcXpAAtaUowx5ex5bsXdz/YLIN5o7iG2+4nTQnslKG4aqL0I/V5S0
JTM5rf6pEgGR2B0sS6NWLlB7H8HD9sU8MjKBxME0j04v6+pmjJm1VNwusJu1yOpdE+gM
NiWQUvhGEeWCxnqN6hywQwf/UnBDWSWPmxFJs1g51iGvT/v0zwLD/SXzL0mQy9Q3tgyw
ZEwQ==
X-Gm-Message-State: AOJu0YxB783dcUwIRJvs2f5IIW6PWu+SF2J8nxfeLZZpshhrXZb2eQC7
aKuisFLyipxPUNLhtJHCQ6UuYg1dCDXgbGQPZBWnQ3D8oMeItHoFxXxWhsDPUfwSUA7XQCSKx2c
4ljk=
X-Gm-Gg: ASbGncsP09BTYny15XuZjvtUeVMzDijGXe5kjMf2NueOcxxiWIFWE+NzH5DYP8KpYp8
QYFckyYxgvWKVYLaD2/OqPABktDyPQxS4Pk6u8JvjXcfO9PD7DWt8FykuXyDEZomy6ApE/1BqkS
aVZaGSpcEBZV2nX5BDzWcgpa/I9Wr7BPwQLIELaQRoB4Pthawf32JjxW0gREOoaM0hHBniSOcyZ
FeDxUfsT7xobQrnTEmPQ0XVpv8YTXoG32+rKWJiYt3pLoj1nuHWWsa0xPnyP16HEyg68KKirf33
n8RCCvbTmZHNefRF+G9BGL6h2+nlhPWIZXwHfNoPHdLisfbsDGDYE+ay5M8+a9wWnF3ZrA==
X-Google-Smtp-Source: AGHT+IHYbhuTHMHJd5dWMb3mDbKsZCqfmVr0r/kU/rXgj2jRHM87iYFUPLlX8WeXa0kKezz1c6iccA==
X-Received: by 2002:a05:6512:b90:b0:543:e0c9:1d97 with SMTP id 2adb3069b0e04-54414a9ced8mr735306e87.12.1738931646039;
Fri, 07 Feb 2025 04:34:06 -0800 (PST)
Received: from localhost (static.57.82.181.135.clients.your-server.de. [135.181.82.57])
by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54410555a3csm433191e87.78.2025.02.07.04.34.05
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 07 Feb 2025 04:34:05 -0800 (PST)
Date: Fri, 7 Feb 2025 13:34:04 +0100
From: Roland Kammerer <roland.kammerer@linbit.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Message-ID: <Z6X9vOv2lCsvTy3o@arm64>
References: <mailman.122.1738918965.293.pve-devel@lists.proxmox.com>
<56159490.3085.1738919922263@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56159490.3085.1738919922263@webmail.proxmox.com>
User-Agent: Mutt/2.2.13 (2024-03-09)
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.003 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DMARC_PASS -0.1 DMARC pass policy
RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com]
On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Gr�nbichler wrote:
>
> > Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com> hat am 07.02.2025 10:02 CET geschrieben:
> > Hi all,
> >
> > rather simple question I guess, but I could not find the answer in
> > https://pve.proxmox.com/wiki/Storage_Plugin_Development and linked
> > documents and looks like my grep foo is lacking today, so here we go:
> > I guess I know what the first hash in the 'content' array is, but what
> > is the second? Actually, why is there a second one?
> >
> > Storage/LVMPlugin.pm:
> > content => [ {images => 1, rootdir => 1}, { images => 1 }]
> >
> > vs.
> >
> > Storage/LvmThinPlugin.pm:
> > content => [ {images => 1, rootdir => 1}, { images => 1, rootdir => 1}]
> >
> > Best, rck
>
> the first one defines the allowed/valid content types, the second the default one(s):
thanks Fabian and Fiona, that explains it.
> we are working on improving the docs and cleaning all of this up!
that is great news, even after maintaining a plugin for some time it
usually takes a deep dive into some core code to actually understand
some of the API. If there is then something to review or give feedback
from an external plugin dev's point of view feel free to explicitly ping
me.
Best, rck
--===============0093945683035962146==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============0093945683035962146==--