From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4EBF21FF17C for ; Wed, 9 Jul 2025 18:23:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 50D5211407; Wed, 9 Jul 2025 18:22:48 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Wed, 9 Jul 2025 18:21:54 +0200 In-Reply-To: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> References: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-storage 05/13] plugin: add qemu_img_resize Content-Type: multipart/mixed; boundary="===============8556795357628662864==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============8556795357628662864== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 99362D7B3B for ; Wed, 9 Jul 2025 18:22:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7FAEC10B84 for ; Wed, 9 Jul 2025 18:22:16 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Jul 2025 18:22:14 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id F3600862E4E; Wed, 9 Jul 2025 18:22:04 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id F0F5710CBC9B; Wed, 9 Jul 2025 18:22:04 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 05/13] plugin: add qemu_img_resize Date: Wed, 9 Jul 2025 18:21:54 +0200 Message-Id: <20250709162202.2952597-10-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> References: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.039 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record and add missing preallocation https://github.com/qemu/qemu/commit/dc5f690b97ccdffa79fe7169bb26b0ebf06688bf Signed-off-by: Alexandre Derumier --- src/PVE/Storage/Plugin.pm | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index b7c9524..ed310a2 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -733,6 +733,30 @@ sub qemu_img_measure { return PVE::Storage::Common::run_qemu_img_json($cmd, $timeout); } +=pod + +=head3 qemu_img_resize + + qemu_img_resize($scfg, $path, $format, $size, $timeout) + +Resize a qemu image C<$path> with format C<$format> to a target Kb size C<$size>. +Default timeout C<$timeout> is 10s if not specified. +=cut + +sub qemu_img_resize { + my ($scfg, $path, $format, $size, $timeout) = @_; + + die "format is missing" if !$format; + + my $prealloc_opt = preallocation_cmd_option($scfg, $format); + my $cmd = ['/usr/bin/qemu-img', 'resize']; + push $cmd->@*, "--$prealloc_opt" if $prealloc_opt; + push $cmd->@*, '-f', $format, $path, $size; + + $timeout = 10 if !$timeout; + run_command($cmd, timeout => $timeout); +} + # Storage implementation # called during addition of storage (before the new storage config got written) @@ -1284,9 +1308,7 @@ sub volume_resize { my $format = ($class->parse_volname($volname))[6]; - my $cmd = ['/usr/bin/qemu-img', 'resize', '-f', $format, $path, $size]; - - run_command($cmd, timeout => 10); + qemu_img_resize($scfg, $path, $format, $size, 10); return undef; } -- 2.39.5 --===============8556795357628662864== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============8556795357628662864==--