From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B80361FF15C
for <inbox@lore.proxmox.com>; Wed, 19 Mar 2025 10:51:21 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id ABDD46221;
Wed, 19 Mar 2025 10:51:08 +0100 (CET)
To: <h.duerr@proxmox.com>, <lou.lecrivain@orange.fr>,
<pve-devel@lists.proxmox.com>
Date: Wed, 19 Mar 2025 09:50:27 +0000
References: <20250306110831.6426-1-lou.lecrivain@orange.fr>
<20250306110831.6426-2-lou.lecrivain@orange.fr>
<08362efa-5bd4-4fd4-b364-d9e14af7196d@proxmox.com>
In-Reply-To: <08362efa-5bd4-4fd4-b364-d9e14af7196d@proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.122.1742377868.416.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Lou Lecrivain via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Lou.Lecrivain@wdz.de, jonatan.crystall@gwdg.de
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [!!ACHTUNG extern!!] - Re: [PATCH pve-network v3
1/3] ipam: nautobot: base plugin
Content-Type: multipart/mixed; boundary="===============8586211816845562759=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============8586211816845562759==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <Lou.Lecrivain@wdz.de>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C6136CA43A
for <pve-devel@lists.proxmox.com>; Wed, 19 Mar 2025 10:51:07 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 9DD6A6163
for <pve-devel@lists.proxmox.com>; Wed, 19 Mar 2025 10:50:37 +0100 (CET)
Received: from FR5P281CU006.outbound.protection.outlook.com (mail-germanywestcentralazlp170120004.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20c::4])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (secp384r1) server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 19 Mar 2025 10:50:36 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=iVROiVNk8UPno0j9Oii/kg7a+4Tc+vFRI2AOAqXvmdQDwiYAFBVw5YLH6lfJUUZK+Hl9Vd8XhAwTBTYuP41Q8uOV4maNtJOqbHY03v8cZTJ4qZD66ZbEZRk/f8ohJpSAkmXG9GnBlEY766Ixz3qa7lLS9jbnh8K53Qb/+FzfddhwJG3Z/HxyFmhJMy6teFR9rReDS/99SeiAehR9ipSOTNHgQ+ME6Gob+rhngHVnU5mK5koSM7NJ+D6bFaHLRXHZnbhEGDtsOt+PxKq3Kod9/sN+VHe0loJNBRidFoT128+n8Rcu5r+uvoJ+GLY6YQKDOFbZjnlqjddwlszzqfb+/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VUXpoJrROTrcFYGOOm6NoWJPPOcYVvyoT8x0iz8ptCc=;
b=gqRRWkliQMoEZUjbPeCcCbkoKdx45pQavEJCB9dfbpPW/D5l337ae2FRtaq7Pnnv4NI1/vHCirCErqabgLvdufVwpV2tW2mjQ3y/n7aXkT2IvHA2Na7vEBL5MJoVpqYarY6BaCtHRorn5rZAc0UW9zzcaSz6Y97EzPmHzq9PkFNzwrnBWUZG9TCsz2gDFP0ZVYDFVxxjz3pEIvWCiercLqule2s3BnGIEdFSHQAHCSJUcvPqlihWuzeaEIr2tlbayTnjn2qO6D/xxRNqdrvGdnDZWmd9PCjdt+C/4hPmE47/vcyz5bYnwI47rCee8eDY5vft0wENwtLomdbyKrekaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=wdz.de; dmarc=pass action=none header.from=wdz.de; dkim=pass
header.d=wdz.de; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=lswnetz.onmicrosoft.com; s=selector1-lswnetz-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VUXpoJrROTrcFYGOOm6NoWJPPOcYVvyoT8x0iz8ptCc=;
b=OQT15HYDG1f35EXQCR7SzZtqwNmk3AZjsxFI+yB8FrzyumeV/GAF5aCsKWmHF1wr2UsAxnNw/d1v5tw5JcKYpSvLs/KB2HC/WP7OpU2Ec3peIQK8QUp3fg+kLbBugFPsIiAayhRhGNB5eBU3fc1XYoc/V6bz1bavwrnZaWmsUTE=
Received: from FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d18:2::2e)
by BE1P281MB1651.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:1e::9) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Wed, 19 Mar
2025 09:50:28 +0000
Received: from FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM
([fe80::e9be:62fd:393f:d4fd]) by FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM
([fe80::e9be:62fd:393f:d4fd%5]) with mapi id 15.20.8534.031; Wed, 19 Mar 2025
09:50:27 +0000
From: <Lou.Lecrivain@wdz.de>
To: <h.duerr@proxmox.com>, <lou.lecrivain@orange.fr>,
<pve-devel@lists.proxmox.com>
CC: <jonatan.crystall@gwdg.de>
Subject: RE: [!!ACHTUNG extern!!] - Re: [PATCH pve-network v3 1/3] ipam:
nautobot: base plugin
Thread-Topic: [!!ACHTUNG extern!!] - Re: [PATCH pve-network v3 1/3] ipam:
nautobot: base plugin
Thread-Index: AQHbmLBJ8S0t9V48vk+WXG6HfcFjVLN6MA4q
Date: Wed, 19 Mar 2025 09:50:27 +0000
Message-ID: <FR2PPF45D006270BAE05B48B2B7C1D2E18F85D92@FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM>
References: <20250306110831.6426-1-lou.lecrivain@orange.fr>
<20250306110831.6426-2-lou.lecrivain@orange.fr>
<08362efa-5bd4-4fd4-b364-d9e14af7196d@proxmox.com>
In-Reply-To: <08362efa-5bd4-4fd4-b364-d9e14af7196d@proxmox.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=wdz.de;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: FR2PPF45D006270:EE_|BE1P281MB1651:EE_
x-ms-office365-filtering-correlation-id: 70e54196-31ac-4ca8-a64b-08dd66cb7a9d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|10070799003|376014|38070700018;
x-microsoft-antispam-message-info: =?Windows-1252?Q?5A++jZkaySIu64fDOclYJTeZBOO0sE98aBsscrT3GWEz0awpDMzXeGWA?=
=?Windows-1252?Q?pp19yaCc3ZTtbdNszPuUpd1ed+q7M5NKuiGySI4q1D65en2xHzbVr0oz?=
=?Windows-1252?Q?7I2YCon6CFe9/HApMSA7y/UNNvavEQ1a2bz3E5Yh4sxla4R5tkc9FiH3?=
=?Windows-1252?Q?u8sg8EopRzprdiT50zC71OwFpIMmJit8tE7Cx1Ap04+3Ab2u5BVgDDTf?=
=?Windows-1252?Q?mUXD/1XHIl73Co8Kziw/NkHgzQWNWx2RhQFLKzTl6VxT0sMCgc4ldUP7?=
=?Windows-1252?Q?nxIm3/qxpnN4RekYNFn+zkpklRuUxKiGCyRxQHo1Sz5py/fEK14b5GcU?=
=?Windows-1252?Q?xmH8DWdx8/HS+ixizaGzOtmP8dn89gzsW9n/wcqIIYnwt1zYf1qLYy9i?=
=?Windows-1252?Q?pXhdgpjX/SFz44GrzAA6FAA0S65yXwy6I8NlB0mpjwmLBHLddkS2eznu?=
=?Windows-1252?Q?UUBl56WfdtrDSRxw2kDfKEWcoeVPuZFPXvL1wV9o0vl3AITiJmc5FdcS?=
=?Windows-1252?Q?31l3rBtQ7nqykT1O3Xv+a6lnxFA+GFp+EQh2Q0Ws9ddzHd1cNAn4cOEY?=
=?Windows-1252?Q?AAgWZGrLGHWia//9iQQd0RkGVSgzQ7q6rty+BoBh/h2C58ztkRsigvKo?=
=?Windows-1252?Q?JnUXm04mSLvAWKOFkMLhGtysl8LX8eiUPKj1Dj+Q5kWhTwC/6UYO+kWb?=
=?Windows-1252?Q?bKZxO4cmITIBC0R5SQjjNY6y1uxQXPidpo/WlRvp/fy68iFCy1LGOCp3?=
=?Windows-1252?Q?kz7sq3T+IQfLHuAsrK0HV6txXL9Yu0UePcXbsc6SmyUPTQNf3DqvYM7T?=
=?Windows-1252?Q?C8aamiFAqSap7eQwT+AiaMvD+pZ/Yj4xdtQyRlE1hCfnxTD0hg258bLK?=
=?Windows-1252?Q?Xx261W+A2tSpKAEkNcVTyj7vAoiRRYyiKV8FMRuKxNzuWICYcZ0nbc15?=
=?Windows-1252?Q?mVNHCQRt0XGv0DQrvsu4VpR+sAh21PpOWmaIofnk3YcjFFeLmLrnxBry?=
=?Windows-1252?Q?hxMMpjCzHIVr3l/mM1xOkBJUImgSC5JU/uVYfEqyrkQwt3Zp7U4GPx3A?=
=?Windows-1252?Q?EIWKyJtMygF76NWly9yJDL7PYcHpXmxrzKDmolCUBVo7bSnZVMyGnoVK?=
=?Windows-1252?Q?gmfK7EEt3b/RJg0DEBzAoGQyVdb0vcILC++e8EmlDkpQ6/w/U7iM33tk?=
=?Windows-1252?Q?m+RHJC+lItb87JBiaTzxSH+WAVGskU0sNzzvd4DpriNxOt1ILXhttnqM?=
=?Windows-1252?Q?g0yQJFZE6G2hP2D2cU23XsjT2MrMAWq2UX33n/AmKk7SuKIlB26cKQNT?=
=?Windows-1252?Q?UfA92bSRdKm9WIxgtRYeYYYKgKx/eR8emPeykVpBcB/rD+pt+dbc+XUz?=
=?Windows-1252?Q?frODnWNGnOJDuUUb3SJignT3ukiGeMRaXZ+8kTibnVRT0W6UaCingO5o?=
=?Windows-1252?Q?HR4tc0OMsAlM1w4IOyheTj5v4sOsaouITi2NOS54fdqmPdt5MJbs2TG6?=
=?Windows-1252?Q?lIHitnm/?=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(10070799003)(376014)(38070700018);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?Df5DCaitwLMwvIHo7pHKWwVa5/6afyJ85vPCztozz/blX927K8BweT2S?=
=?Windows-1252?Q?ey+GTlXfDSuGvp7KASRil5iFJiN1itbhrF77pfWImNFDe/MLfX4xSzOe?=
=?Windows-1252?Q?BahcTxbzEkwYabc3oeNDTgN3HnETjjtHhsGm9yKuDR2M7wy3+Y1pCjj9?=
=?Windows-1252?Q?HWIPBjK29R5nMS2LTOn1BaEI2KBYknkaMqK6XAh7MyJXJobXGTB1WPyC?=
=?Windows-1252?Q?1XnBKEomGdIfxYhEwW80dONJL4+n07C9Wkp47P0BI/6RORV5LfcC+k4j?=
=?Windows-1252?Q?FllOFvDDDJsL5DMK5I6BQWpnpAcFrz1GjWvRXH3nVPl55CcYFectLISI?=
=?Windows-1252?Q?nuE3KnW9dJYPTcE67gJzW1ujHK2NXMbp8ShnovexxH3ftTtrF2OJG7ig?=
=?Windows-1252?Q?+mKbMpFwKIPIY0H6fm3SzCI7hEnn5BG/SxKTjqRSCOugyVkTSY2vcE6p?=
=?Windows-1252?Q?iMsfp0Fft3W1KI35SnRL3z/yjVJGZtb22uxr8G4Lc92dwts3DdMwtdj0?=
=?Windows-1252?Q?l2fzpq/qIE1D5q2JiBFzKOHBFfGv8pcfYuL6TP37S5uDEqrT6d6ofS4A?=
=?Windows-1252?Q?wFEQzrw1fgwcuXQ+lqk2kxyvH149L1sON4MSIqhFfB63USRo/iwararj?=
=?Windows-1252?Q?f9uFNLS+4OM0p8PEeutv/ek9pOyFkzR8ajGQz0Q/2eqFl/BWArQOh22q?=
=?Windows-1252?Q?6WswbqspZIYMaFXGXXtohIThDfox/0fJwr2iSPI7NiLWzV7loDeykE0j?=
=?Windows-1252?Q?YVQv1Cam6Q/w8f5VueU30oyjl90QZMDM64MQbmcBUWRT/6Q093g6HXVc?=
=?Windows-1252?Q?J3+kJu7wbxixTZFnoKQVnPNYyc2kjh5REop6V60UzHs4NC5uLesQr94i?=
=?Windows-1252?Q?HoxLTOsIIMdf7pfb+eaEcbfPLFmawSzxU69F9DbKYlTgd95Ejz8KL3jX?=
=?Windows-1252?Q?+qioN81hywnq+W5Ul4OjC+mPf9CBuOaOsHmEPntuup5lPje9o2XoD11J?=
=?Windows-1252?Q?8DBChMeIdQGxCUKKZyivv96RP7ZJrsUXZtQUrK5SQwnjh0DHrVs/fplw?=
=?Windows-1252?Q?/pk4UNuLfNFFJShv7UjCDXwXzFNyxMNYfRLvXYkBgD6T2dtotl4xEBks?=
=?Windows-1252?Q?yNgvJoLjZoYgrmh6+xsY6UbW1qSetLYWpmDk/y07uRkv6Ra9OUZufm7+?=
=?Windows-1252?Q?ChdYgkh2wR0skRTVU3Cyertev8DzfQTyOvrnKP1FyuKb1fKqugoAyt74?=
=?Windows-1252?Q?kBYxsUq/M26PGEcszf0UOqqfRGEQa2O5+1QwY6avWLhWvVc16tp587hC?=
=?Windows-1252?Q?u7fz52lcE95G6go1BttYibCqJlxdG5NIN+0yxRrIlBnElbJp5xH36RY/?=
=?Windows-1252?Q?6F7q1r+fAo4NsY0lUjCR6XYO9wAyOrVqeW5JRv/oGPmKeN8GhSuv+c7+?=
=?Windows-1252?Q?1GBR4Kg2TBZgpgJPgJNpZL7KaNQBXFctJsQqZJDicSgi96RMY6CjF+KN?=
=?Windows-1252?Q?swY33XrVEkbAyVKt2WIRQeXx1XY9JfokLJg2iXU6vkDm6dD8OuzJHa5U?=
=?Windows-1252?Q?6AKHKKQTq894I2lR/nAVm5dDbxbelAy99iI4aXQ4Iwia4hFeYJa772Zl?=
=?Windows-1252?Q?Zkl/T8O/fhfJERPI9v692f25hCyqq6yswRoNbMIbdq9KOjCxpiZ4Gh1m?=
=?Windows-1252?Q?QiiJ7oEeXz0i16VNa7+Fc+m+iLC7Tp2n5Cl8sNc3YeCENHIY+rd+f+dR?=
=?Windows-1252?Q?1VFCy6PnIZs8ZEZ7LasWvGPK9JDpnrKHqNGbJvmH?=
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdz.de
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 70e54196-31ac-4ca8-a64b-08dd66cb7a9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2025 09:50:27.7188
(UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d1b757c4-c391-4d47-b0de-c8365891bd6b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SdhAluF8VumzDlA8wdZyypTUASsC9gQIOat4KiMXED7+F78+V7cm7ca0gdYerxtPeOUX8kxUptVV+9FIq4E5/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BE1P281MB1651
X-SPAM-LEVEL: Spam detection results: 1
ARC_SIGNED 0.001 Message has a ARC signature
ARC_VALID 0.001 Message has a valid ARC signature
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DMARC_PASS -0.1 DMARC pass policy
FORGED_SPF_HELO 1 -
KAM_MAILER 2 Automated Mailer Tag Left in Email
SPF_HELO_PASS -0.001 SPF: HELO matches SPF record
T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror)
Re,=0A=
=0A=
Ok so. Answering on that.=0A=
=0A=
By default, the status "Active" already exists for fresh installs. However,=
=0A=
since the users are free to define whatever status they want (and delete th=
e=0A=
pre-existing ones!), I thought it'd be best if we checked it did exist firs=
t.=0A=
There could be a case where we use a Nautobot instance where the status=0A=
"Active" does not exist. But I agree it's a bit far-fetched.=0A=
=0A=
I wrote it this way since IMO it is better to have an explicit error messag=
e=0A=
rather than something like "incorrect API request" on subsequent API calls =
with=0A=
potentially no more details.=0A=
=0A=
HTH=0A=
=0A=
________________________________________=0A=
De :=A0Hannes D=FCrr <h.duerr@proxmox.com>=0A=
Envoy=E9 :=A0mercredi 19 mars 2025 10:21=0A=
=C0 :=A0lou.lecrivain@orange.fr <lou.lecrivain@orange.fr>; pve-devel@lists.=
proxmox.com <pve-devel@lists.proxmox.com>=0A=
Cc=A0:=A0jonatan.crystall@gwdg.de <jonatan.crystall@gwdg.de>; Lecrivain, Lo=
u (WDZ) <Lou.Lecrivain@wdz.de>=0A=
Objet :=A0[!!ACHTUNG extern!!] - Re: [PATCH pve-network v3 1/3] ipam: nauto=
bot: base plugin=0A=
=A0=0A=
=0A=
On 3/6/25 12:08, lou.lecrivain@orange.fr wrote:=0A=
=0A=
[...]=0A=
=0A=
> +sub verify_api {=0A=
> +=A0=A0=A0 my ($class, $plugin_config) =3D @_;=0A=
> +=0A=
> +=A0=A0=A0 my $url =3D $plugin_config->{url};=0A=
> +=A0=A0=A0 my $namespace =3D $plugin_config->{namespace};=0A=
> +=A0=A0=A0 my $headers =3D default_headers($plugin_config);=0A=
> +=0A=
> +=A0=A0=A0 # check that the namespace exists AND that default IP active s=
tatus=0A=
> +=A0=A0=A0 # exists AND that we have indeed API access=0A=
> +=A0=A0=A0 eval {=0A=
> +=A0=A0=A0=A0 get_namespace_id($url, $namespace, $headers, 0)=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0 // die "namespace $namespace does not exist";=
=0A=
> +=A0=A0=A0=A0 get_status_id($url, default_ip_status(), $headers, 0)=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0 // die "default IP status ". default_ip_status(=
) . " not found";=0A=
> +=A0=A0=A0 };=0A=
> +=A0=A0=A0 if ($@) {=0A=
> +=A0=A0=A0=A0 die "Can't use nautobot api: $@";=0A=
> +=A0=A0=A0 }=0A=
> +}=0A=
> +=0A=
=0A=
[...]=0A=
=0A=
> +sub get_status_id {=0A=
> +=A0=A0=A0 my ($url, $status, $headers, $noerr) =3D @_;=0A=
> +=0A=
> +=A0=A0=A0 my $result =3D eval {=0A=
> +=A0=A0=A0=A0 return PVE::Network::SDN::api_request(=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0 "GET", "$url/extras/statuses/?q=3D$status", $he=
aders);=0A=
> +=A0=A0=A0 };=0A=
Unfortunately, I don't quite understand what this check actually does,=0A=
or why we need this check.=0A=
The documentation [0] says:=0A=
`Nautobot provides the ability for custom statuses to be defined=0A=
within an organisation to be used on various objects to facilitate=0A=
business workflows around object statuses.`=0A=
=0A=
And as I understand the API call, it checks whether the=0A=
status object =91Active=92 exists and gets its ID. But I don't=0A=
understand why this should be checked with `verify_api`?=0A=
In my opinion, we don't really need this check, unless I'm missing=0A=
something here.=0A=
=0A=
[0]=0A=
https://docs.nautobot.com/projects/core/en/stable/user-guide/platform-funct=
ionality/status/=0A=
=0A=
> +=A0=A0=A0 if ($@) {=0A=
> +=A0=A0=A0=A0 die "error while querying for status $status id: $@" if !$n=
oerr;=0A=
> +=A0=A0=A0 }=0A=
> +=0A=
> +=A0=A0=A0 my $data =3D @{$result->{results}}[0];=0A=
> +=A0=A0=A0 my $internalid =3D $data->{id};=0A=
> +=A0=A0=A0 return $internalid;=0A=
> +}=0A=
--===============8586211816845562759==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============8586211816845562759==--