From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0D4BE1FF17C for ; Wed, 9 Jul 2025 18:22:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7459010E4D; Wed, 9 Jul 2025 18:22:24 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Wed, 9 Jul 2025 18:21:58 +0200 In-Reply-To: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> References: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH pve-storage 09/13] storage: add volume_support_qemu_snapshot Content-Type: multipart/mixed; boundary="===============4662312123441088687==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============4662312123441088687== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 13D7BD7A6F for ; Wed, 9 Jul 2025 18:22:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9FDA610D3C for ; Wed, 9 Jul 2025 18:22:19 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [185.151.190.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Jul 2025 18:22:15 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 1509D862E57; Wed, 9 Jul 2025 18:22:05 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 128A410CBC9B; Wed, 9 Jul 2025 18:22:05 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 09/13] storage: add volume_support_qemu_snapshot Date: Wed, 9 Jul 2025 18:21:58 +0200 Message-Id: <20250709162202.2952597-14-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> References: <20250709162202.2952597-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.039 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Returns if the volume is supporting qemu snapshot: 'internal' : do the snapshot with qemu internal snapshot 'external' : do the snapshot with qemu external snapshot undef : does not support qemu snapshot Signed-off-by: Alexandre Derumier --- ApiChangeLog | 8 ++++++++ src/PVE/Storage.pm | 15 +++++++++++++++ src/PVE/Storage/DirPlugin.pm | 10 ++++++++++ src/PVE/Storage/LVMPlugin.pm | 7 +++++++ src/PVE/Storage/Plugin.pm | 20 ++++++++++++++++++++ src/PVE/Storage/RBDPlugin.pm | 6 ++++++ 6 files changed, 66 insertions(+) diff --git a/ApiChangeLog b/ApiChangeLog index 12eef1f..68e94fd 100644 --- a/ApiChangeLog +++ b/ApiChangeLog @@ -29,6 +29,14 @@ Future changes should be documented in here. * Introduce rename_snapshot() plugin method This method allow to rename a vm disk snapshot name to a different snapshot name. +* Introduce volume_support_qemu_snapshot() plugin method + This method is used to known if the a snapshot need to be done by qemu + or by the storage api. + returned values are : + 'internal' : support snapshot with qemu internal snapshot + 'external' : support snapshot with qemu external snapshot + undef : don't support qemu snapshot + ## Version 11: * Allow declaring storage features via plugin data diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index e0b79fa..b796908 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -2370,6 +2370,21 @@ sub rename_snapshot { ); } +sub volume_support_qemu_snapshot { + my ($cfg, $volid) = @_; + + my ($storeid, $volname) = parse_volume_id($volid, 1); + + if ($storeid) { + my $scfg = storage_config($cfg, $storeid); + + my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); + + return $plugin->volume_support_qemu_snapshot($storeid, $scfg, $volname); + } + return undef; +} + # Various io-heavy operations require io/bandwidth limits which can be # configured on multiple levels: The global defaults in datacenter.cfg, and # per-storage overrides. When we want to do a restore from storage A to storage diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm index 10e4f70..3e92383 100644 --- a/src/PVE/Storage/DirPlugin.pm +++ b/src/PVE/Storage/DirPlugin.pm @@ -314,4 +314,14 @@ sub get_import_metadata { }; } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return if $format ne 'qcow2'; + + my $type = $scfg->{'external-snapshots'} ? 'external' : 'internal'; + return $type; +} + 1; diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 2441e59..be411e5 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -861,4 +861,11 @@ sub rename_snapshot { die "rename_snapshot is not implemented for $class"; } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return 'external' if $format eq 'qcow2'; +} + 1; diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 6b2dc32..aab2024 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2262,6 +2262,26 @@ sub new_backup_provider { die "implement me if enabling the feature 'backup-provider' in plugindata()->{features}\n"; } +=pod + +=head3 volume_support_qemu_snapshot + + $blockdev = $plugin->volume_support_qemu_snapshot($storeid, $scfg, $volname) + +Returns a string with the type of snapshot that qemu can do for a specific volume + +'internal' : support snapshot with qemu internal snapshot +'external' : support snapshot with qemu external snapshot +undef : don't support qemu snapshot +=cut + +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + return 'internal' if $format eq 'qcow2'; +} + sub config_aware_base_mkdir { my ($class, $scfg, $path) = @_; diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index ee33006..45f8a7f 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -1061,4 +1061,10 @@ sub rename_snapshot { die "rename_snapshot is not implemented for $class"; } +sub volume_support_qemu_snapshot { + my ($class, $storeid, $scfg, $volname) = @_; + + return 'internal' if !$scfg->{krbd}; +} + 1; -- 2.39.5 --===============4662312123441088687== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============4662312123441088687==--