From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 287AA1FF168 for ; Tue, 10 Dec 2024 14:19:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 960921CFF3; Tue, 10 Dec 2024 14:19:53 +0100 (CET) To: , Date: Tue, 10 Dec 2024 13:19:41 +0000 References: <9553725a-a0a4-44e4-87f6-cc5d2d347424@proxmox.com> In-Reply-To: <9553725a-a0a4-44e4-87f6-cc5d2d347424@proxmox.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Lou Lecrivain via pve-devel Precedence: list Cc: Lou.Lecrivain@wdz.de X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] SPAM: [PATCH pve-network 00/16] add support for Nautobot IPAM Content-Type: multipart/mixed; boundary="===============3865444076409230197==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============3865444076409230197== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C3F82C1CD3 for ; Tue, 10 Dec 2024 14:19:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B5D5E1D056 for ; Tue, 10 Dec 2024 14:19:52 +0100 (CET) Received: from mail2.lsw.de (mail2.lsw.de [62.176.232.134]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Dec 2024 14:19:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdz.de; i=@wdz.de; q=dns/txt; s=wdz201805; t=1733836792; x=1765372792; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=Ch1X442DAq0XAdd8hsRAI9RO78bIdjkMii4h9XShyAY=; b=p7/zHiDhFXWq3nDarZSFYFVohp5689TRUJyw6G9DSrYJWk1D0aUcQ7at Bi7Gzxc22WudzlNhmWeIPN+kQmqY8k6Datn1Q7sw9ChErG4D9EsYkRnQ/ TnoAe2RKtaU13xmlJwWYPzdhGsZZiYuANbHBc+lBOfQKYkMcS5VZ0vZb5 2dQteIpcxWp+Rz6mzx+OnH6pJQ5+9MheVm5gIAW1DPwlbeeLPePLr4CBh gxfx93f9LzuDVQeCVbGKqnKaEY+F9WAfvI45FZn2q7TVC3JXsIF0j10Fp me/M3cjOdUzJydb34HYgw04bCmHlJsU2n+Y7A1XQ3SwrtdbMFlMBHr0LD A==; X-CSE-ConnectionGUID: S33nXt2jRVG1JUE1wwN9Vw== X-CSE-MsgGUID: uPAf+aMMSSC0Xdeq9eiPSQ== X-IronPort-AV: E=Sophos;i="6.12,222,1728943200"; d="scan'208";a="20218958" Subject: RE: Re: [pve-devel] SPAM: [PATCH pve-network 00/16] add support for Nautobot IPAM Received: from internalmail by mail1.lsw.de; 10 Dec 2024 14:19:45 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eqOtZI8wztByvjXPoQ+fpDhqkpweVRYtDxmNi8UEhPo5N6nh+dvuduKKVXkaZSSJhXOhKkFUwkYb2vRHzg0oHPhAFk/UH8uCH9bc4kREMmVwY4jWCwUEKJsG142jLN6+CALTckjoZz7QByGbYj8wzomn3yoaU5WZREkpAWbUAUuK5cjqpYRrvdI5lf/lzDu4I6VNnwQjBB8tuHqRZFDxjWq1s7o/egjk1CYCf87evRjyN/jInfNzgJUjzD+AI0ACgOj5MPLw2X6Hm1fywZqGvNizDbYSI5tLfGpkd0wxK0n/zZSZ5gx2vGjJ2oD+rTPAUt9MX+ABzUpj2F9kaRLpUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ch1X442DAq0XAdd8hsRAI9RO78bIdjkMii4h9XShyAY=; b=ESgy6kSPvptnsYhnsmSfAAozuGsDvyamV6QJz+Q7hd3VdpjQrYl0rK3Iu7llfbQKWzX3QB76Hr23k16679+vxRVU9DpsLEnZeHBCVhMzwNvwrGF6g91b1mgFU0OjUtfJ43byfbZQWtwrtuHQOOaf75CIma2xDLjZyH1CJl78uluiIeJ1EMuyfdtL7KSJuMLcUewkQiWs0B0EILuC2z2TVSE3kD1gjlnYrF8Xyeh7PTRahS0wLi6aFjPpZeEYuvGlLIedj1d0q/tBgbZ9MIwC3k6X53bkm8GLPIHWzfmJr4RZu7n1Y47xillvp3KIQHu1GfqXV2n785AgXWQbxCpOsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdz.de; dmarc=pass action=none header.from=wdz.de; dkim=pass header.d=wdz.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lswnetz.onmicrosoft.com; s=selector1-lswnetz-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ch1X442DAq0XAdd8hsRAI9RO78bIdjkMii4h9XShyAY=; b=UrzWw1Y3gFa7TruODcXkHYcfNNEcnPkU6HZnGWFEBwPNd0X5MwPx8+10qfdaDekISvl6Cmsj2S9l3KWUsrW1IQodQP4TLWROdQGe+IghAqBmkm+NBQjOV31HtXBH57ZOVtCYvAXFDE9uXtZZhO7xKVZK8J9/ZYT/DYzVtmmO3Pk= From: To: , Thread-Topic: [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 00/16] add support for Nautobot IPAM Thread-Index: AQHbSuZ//4BQoTEdvUyQ8igAatRCoLLfciYa Date: Tue, 10 Dec 2024 13:19:41 +0000 Message-ID: References: <9553725a-a0a4-44e4-87f6-cc5d2d347424@proxmox.com> In-Reply-To: <9553725a-a0a4-44e4-87f6-cc5d2d347424@proxmox.com> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wdz.de; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BE1P281MB2116:EE_|FR1PPF52AFD452D:EE_ x-ms-office365-filtering-correlation-id: acdb2cb9-1429-47c4-c272-08dd191d4e92 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?Windows-1252?Q?UIUm1vJtooojXD+vs0nU/QJSExaXOhvzky+7sCIE4Dz7qeaf/M8E8V75?= =?Windows-1252?Q?0gWmXmrLXJ5K1Qa5KbLgRQA0oAjEdZaJz/u9aKDRZ2b3H6Vezk14HQtl?= =?Windows-1252?Q?nx7U3hYeEmsgkpwy/Cc+lH+jVa3NuodHRt8D1+SRtJRFlBfI8rrm+v+I?= =?Windows-1252?Q?qQLmoF5JR5hEZt0mZdbNeLh29CXqWooXl6KYMHbwPzG9lOqVjGOO5vvM?= =?Windows-1252?Q?7Sz0A22tIjV2NeND2Ai+8iOahLOTBWVPTFs9lzqGKVwlj6zhuZbrjtjD?= =?Windows-1252?Q?1+NWXazs40YDzgwgGprm2dYt2DmLT+0yZVtKANkvvRjA6KISD17cF/Rc?= =?Windows-1252?Q?ZNnk8jCEzNAHIIEQVBko9VQS26Km/vcC3ZCeu/KHU6DcmIWzgVEgxrVs?= =?Windows-1252?Q?cndhxrPrcLJHp2STs8cpyPNsZa4zFQNJhvOf3QokbHiRIgAfuIVT+Ocb?= =?Windows-1252?Q?IQUW4vLXEuCUBpy8d0jTxMXr5d6iPcrWKs0nhAnKaqjCMk2HZZ0f+ffE?= =?Windows-1252?Q?PQ7jyXTIkjxaCrbjiW30+jyXVhek+d8lKLSH8Y5IkyCxAngePCkraS5l?= =?Windows-1252?Q?A72tYdDdg3YYp8P00VaJ/lcG+5ErKMk9CA5TaHsXuFpyvj4w/dbVt+yf?= =?Windows-1252?Q?wyoP85R4cEgmsIeRF4KB5ZnlLhJ5YdKXtYf3XUe0vqKi2Mwr6VamOaOI?= =?Windows-1252?Q?DvvHCoyCxPcCJGSP9IGQQV5J/bnBT/6kdzHOtGjkU5TgL6y596ayifKi?= =?Windows-1252?Q?/RFZas/Ab2t0uN+BofPLAxM1yidkcWjvttVP/fdLZ+6iskc203+wCEqk?= =?Windows-1252?Q?VbGRZZAirlC51JgLHuDBFPEXOltZ3yeM4bAlCXCnM+QsOlCZDIkttyI7?= =?Windows-1252?Q?erdX6jo6uTPR7LFjX5VCuay57QxesxAEml8ZDaDtKqix1028PRnLztnq?= =?Windows-1252?Q?yMR6vQD1ImhA8HcqTPE/4roknnWlX4NxvSUGNHKVQCQEH+50A+Np2BHD?= =?Windows-1252?Q?IhGQeQm8BKw5CWrXRTunMw5Tjm25fxqZIqWK6xMOY1FiuSATPFs0pwP1?= =?Windows-1252?Q?SPop2+j2yWfJOj/ElQBx+dus2FYWkZjG6jdxuJW0815nP3VDd7zzHv6W?= =?Windows-1252?Q?2ork+J+tvdVpuT4Zyk6fnJsCZ3g0SqMmmFhG5UdJtnxlyCkpy9YWjO2l?= =?Windows-1252?Q?HxqZGuBawCL/KXBNy8EoyVgok7USwEIuzwFTMTDfMQOsG8OPm9PhzK7D?= =?Windows-1252?Q?QK9DmF3FqSH0qs6WySZ2qvND00kW13sZRELQs6lY4ZzTAAv6fC72AucE?= =?Windows-1252?Q?6Jof/FzktE2Vhd9btIm0tmLSWmb0fJhMSrMe/qzIyDNLpsJlf/du3g5R?= =?Windows-1252?Q?7zmk88WkOEtLUfJcOnxepIdADVLM0pgfsoQSbFUaMwWHZlACtZY1IQLe?= =?Windows-1252?Q?TMMWpVFoa2dvJCVQRw6n3A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?HGV+RkPNBEgKhSUpf2Q/ofcSPe1+6hEAR7y/UHShpof/VYdFFgOoT1SM?= =?Windows-1252?Q?GE/B4sKz1R8fy0dCsa+KwrE5Autaq3a/3EwfsW181rBwWwWASCDx9Ury?= =?Windows-1252?Q?EfFHDS2BZgPV5OVyqB5TtZDgYcg3RuS7OnKhRMgezPRk5xjUB/LeVDas?= =?Windows-1252?Q?4TIrX9ESOOxyRwAoMQ4r6YU34ACGyyVauYADL4lB5tx5zOaLuJ1y54+W?= =?Windows-1252?Q?NyCGO4JlmHO8nixy/7VvvcjkqHdsGCjch+P1dHCQnVmPc/UqhshBCtt4?= =?Windows-1252?Q?bWl8pSqUFtQiDJ3kV91ArStl0DTNoGEFNEH2vEiD2wsg13H9ky6WdA0T?= =?Windows-1252?Q?/V7kZ9nqpdETK5cw9awV8qSyUVHxxUBW+73YvOVLHP0lRi2oIl1Jcx1q?= =?Windows-1252?Q?n/LNUGH9pn0mNgLVY4hjBW6B35aqVZWjSSu9wCE6jFwZGzeeXllW7W8P?= =?Windows-1252?Q?PQb91K1YuN+EbHeCsRKXoGkaznArh7taiDfw/yD2qQfvvzpKRpXCBTPw?= =?Windows-1252?Q?iWcmSDu5qGG29utUG2Ks4F6LS6R6tlQgjCTCTkV0xPdwgiq1zwYxvMMM?= =?Windows-1252?Q?Ryt7K9BJ588djDB9ly7TdtTdsHIT9x0q/1ImWh4Dy7OzpY+i90lRjY9x?= =?Windows-1252?Q?qwohmfhlrdGG5ybLVPZbbkccoLiB/6javPw844iwKekFFPFOyAgAafU2?= =?Windows-1252?Q?WNMxW85qhuVeMILIHQVdY5Tb4xVfPMCMdBa9DFfs5Aw0hRsORmuhmWLU?= =?Windows-1252?Q?QuC3DPE51tpp24Ox4qhth4D14joOtcpOmXhHCMMhcgfuF0lmxzylFqff?= =?Windows-1252?Q?gyr7xpoAG1BC/+iugKUB6zXNDCTx3sulCBkAPoKxWDGEKZ0mWCd1BqMN?= =?Windows-1252?Q?dNNCZz7Lk6qJ/x/zNebM9XMv2DwXadSbYnLJicdRSFKqSIn1Nlayww7h?= =?Windows-1252?Q?2hr4THrw250cOQuoMAG6tl+zbBNhhP9fJtWlovAQKELrxt4ByWATtWTt?= =?Windows-1252?Q?G3XnSLAk8kVSr8Ez9rgiUv8Gf/yduBDePXwSipS52kiDlrXzOnXiGEzk?= =?Windows-1252?Q?21NF4yr3+80URq0H6ZxUjFM625iNJua0jSPWWP62be3PrWtTwMmB7GIK?= =?Windows-1252?Q?bI47FM5EWVHBqfF+FxqbW13E0uRkk5Kt6s3wD5JVC0swL5WqmerANnZ4?= =?Windows-1252?Q?IQ8wtCBCa/eJrPeYaqGdPEdkKmWUViuHGvtaiXjDeCSv3c5T8g4bL19Y?= =?Windows-1252?Q?n0zpX6D+T0cuu027mQ2B4jGNJDC+G11sp4R7HA8AY5fiI67Q8jWdLtdg?= =?Windows-1252?Q?/+m+pTgQ1iIHRPFeF+RJ+b98HI+x4NEV/nDDJmqj3uC7aYTfKlcm7axC?= =?Windows-1252?Q?4SKm614Gd6/RVSKj8xRR5zBQMoLAcU4+LlqQLatMCZ9jwQKTNXonUB89?= =?Windows-1252?Q?4rQ0dL6t3fhvBQuu6rSbP99fwSpplXYscIwATt1QvPtKTAPK3lP+QeSQ?= =?Windows-1252?Q?wv7KLX3qAXetxshe9shAlFsTF7wHaELKVIwidVBaKIBH4H01mp1Gb0mr?= =?Windows-1252?Q?nXNa97+hNouKqjpQOeRDw7yjVqqv59avSfivwqxhSwy0FdxgW928UwfG?= =?Windows-1252?Q?Y5+LYG+cUxf0pY7BjbTXkzuKB4oFM3hzfuhBolRaw9n7hpKJiTlG4eln?= =?Windows-1252?Q?Mc+pC6qV0LE=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: acdb2cb9-1429-47c4-c272-08dd191d4e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2024 13:19:41.8901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d1b757c4-c391-4d47-b0de-c8365891bd6b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S+ouhc5npSjhRQu/kTStMDtipE2ZkJDIlgUEria0XwHgzYMpOxNohqB5QLOUXIbTEAa+e0VNtPUUQgeggoBu1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR1PPF52AFD452D X-OriginatorOrg: wdz.de X-C2ProcessedOrg: 146dacec-6c92-4c17-8986-3fcc31a486b0 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature AWL -0.172 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lswnetz.onmicrosoft.com,proxmox.com,wdz.de] Hello Hannes,=0A= =0A= Thank you also very much for the feedback, I appreciate it. It's my first t= ime writing Perl and contributing to Proxmox :) I was initially in contact = with your colleague S. Hanreich, who told me to start with the Netbox plugi= n. Given how significant the differences are in the end, I guess it would b= e easier to build from the base plugin, indeed.=0A= =0A= I'll make the necessary changes (code + test + documentation) plus squash a= nd edit a few of these commits and will send you a v2 as soon as possible.= =0A= =0A= I just have a few questions that I'd like an answer to, namely:=0A= =0A= - Is the IPAM IP range support mandatory? Nautobot doesn't support IP range= s natively, only prefix allocations. So far, I have a workaround but it's n= ot really clean... What would be best? ditch the workaround and "die", or k= eep it?=0A= =0A= - We also have a noop/early return in del_subnet, inherited from Netbox Plu= gin (doesn't actually delete the subnet in the IPAM). Do we agree that the = desired operation would to be to error if subnet is not empty? cf:=0A= https://git.proxmox.com/?p=3Dpve-network.git;a=3Dblame;f=3DPVE/Network/SDN/= Ipams/NetboxPlugin.pm;hb=3D70b035064290a014759ce62e0093df00cd7d62fe#l69=0A= =0A= MfG=0A= --=0A= Lou Lecrivain=0A= WDZ GmbH=0A= =0A= ________________________________________=0A= De :=A0Hannes D=FCrr =0A= Envoy=E9 :=A0mardi 10 d=E9cembre 2024 10:32=0A= =C0 :=A0Proxmox VE development discussion =0A= Cc=A0:=A0Lecrivain, Lou (WDZ) =0A= Objet :=A0[!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 0= 0/16] add support for Nautobot IPAM=0A= =A0=0A= Thanks for contributing and sending the patch series, we really=0A= appreciate it!=0A= =0A= At first glance it looks quite good, I have a few suggestions for changes:= =0A= =0A= *=A0 The plugin is based on the Netbox plugin, I would suggest changing it= =0A= =A0=A0=A0=A0 to the base plugin. I know Nautobot is a fork of Netbox, but t= his=0A= =A0=A0=A0=A0 dependency doesn't make things easier in my eyes, unless I'm m= issing=0A= =A0=A0=A0=A0 something, please let me know.=0A= =0A= *=A0 The commit history is currently a bit unnecessarily long and does not= =0A= =A0=A0=A0=A0 build up well. What I mean is:=0A= =A0=A0=A0=A0 - in 1/12 you build the plugin and copy/paste some stuff into = it=0A= =A0=A0=A0=A0 - in 3/12 you delete everything for now=0A= =A0=A0=A0=A0 -> just leave it out=0A= =A0=A0=A0=A0 or=0A= =A0=A0=A0=A0 - in 6/12 you introduce a typo in an url=0A= =A0=A0=A0=A0 - in 7/12 you fix the typo=0A= =A0=A0=A0=A0 Such changes don't need to be committed in the first place,=0A= =A0=A0=A0=A0 so you don't need to fix them 2 commits later.=0A= =0A= *=A0 The commit messages could be a bit longer and more explanatory for=0A= =A0=A0=A0=A0 coming changes: e.g. =93api endpoint change no longer needed= =94 -> Why is=0A= =A0=A0=A0=A0 the endpoint change no longer needed? Is there more background= =0A= =A0=A0=A0=A0 information on this, e.g. a link?=0A= =0A= *=A0 Comments can be helpful to make complex code easier to understand=0A= =A0=A0=A0=A0 after a long time. Comments like '#helper' or '#impl' are not = really=0A= =A0=A0=A0=A0 necessary in my opinion. I know our codebase already contains = such=0A= =A0=A0=A0=A0 comments elsewhere, but I think we can leave them out here :)= =0A= =0A= *=A0 Apart from the tests, the documentation (pve-docs/pvesdn.adoc) is also= =0A= =A0=A0=A0=A0 missing.=0A= =0A= On 11/27/24 17:17, Lou Lecrivain via pve-devel wrote:=0A= > _______________________________________________=0A= > pve-devel mailing list=0A= > pve-devel@lists.proxmox.com=0A= > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel=0A= --===============3865444076409230197== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============3865444076409230197==--