From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 975AE977DF for ; Tue, 5 Mar 2024 13:06:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71148751C for ; Tue, 5 Mar 2024 13:05:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Mar 2024 13:05:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7778D47E60 for ; Tue, 5 Mar 2024 13:05:46 +0100 (CET) Date: Tue, 5 Mar 2024 13:05:45 +0100 From: Christoph Heiss To: Gabriel Goller Cc: Proxmox VE development discussion Message-ID: References: <20240304132221.901327-1-c.heiss@proxmox.com> <20240304132221.901327-7-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH docs 6/9] installation: iso: improve & align wording with pmg-docs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2024 12:06:17 -0000 Thanks for the review! On Tue, Mar 05, 2024 at 09:38:02AM +0100, Gabriel Goller wrote: > On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote: > > +When copying and setting up the packages has finished, you can reboot the > > +server. This will be done automatically after a few seconds by default. > > I would remove the `by default` so that the sentence becomes: > > This will be done automatically after a few seconds. Well, the option to automatically reboot can be changed and is on by default, so it makes sense IMO to have that bit in there. Although the sentence can probably be rephrased a bit to make it read easier - I'll see what I can come up with for v2. > > > +. Log in using the `root` (realm 'PAM') username and the password chosen during > > +installation. > > I think you need to fix the indentation here... > Will do, although we have (esp. in pmg-docs) a mix-match of both styles, since it seems not not matter to asciidoc. I will then probably go about and fix all the other instances too, if I'm already it at .. > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >