From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 93DD21FF185 for ; Mon, 7 Jul 2025 17:19:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 524C036393; Mon, 7 Jul 2025 17:19:56 +0200 (CEST) Date: Mon, 7 Jul 2025 17:19:53 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: Mail-Followup-To: Wolfgang Bumiller , pve-devel@lists.proxmox.com References: <20250702145101.894299-1-g.goller@proxmox.com> <20250702145101.894299-13-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v4 06/22] frr: add openfabric types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 07.07.2025 13:25, Wolfgang Bumiller wrote: >On Wed, Jul 02, 2025 at 04:49:57PM +0200, Gabriel Goller wrote: >> [snip] >> +/// The OpenFabric properties. >> +/// >> +/// This struct holds all the OpenFabric interface properties. The most important one here is the >> +/// fabric_id, which ties the interface to a fabric. When serialized these properties all get >> +/// prefixed with a space (" ") as they are inside the interface block. They serialize roughly to: >> +/// >> +/// ```text >> +/// interface ens20 >> +/// ip router openfabric >> +/// ipv6 router openfabric >> +/// openfabric hello-interval >> +/// openfabric hello-multiplier >> +/// openfabric csnp-interval >> +/// openfabric passive >> +/// ``` >> +/// >> +/// The is_ipv4 and is_ipv6 properties decide if we need to add `ip router openfabric`, `ipv6 >> +/// router openfabric`, or both. A interface can only be part of a single fabric. > >An* writing skills of a 4th-grader -_- thanks! >> +#[derive(Clone, Debug, PartialEq, Eq, Hash, Deserialize, Serialize, PartialOrd, Ord)] >> +pub struct OpenfabricInterface { >> + // Note: an interface can only be a part of a single fabric (so no vec needed here) >> + pub fabric_id: OpenfabricRouterName, >> + pub passive: Option, > >^ So in `FrrSerializer` we do all this manually - but for the derived >`Serialize` implementation, shouldn't we have a >`#[serde(skip_serializing_if = "Option::is_none")` here? > >(and probably also down below...) Umm actually we don't need serde (and Serialize, Deserialize) in proxmox-frr at all. My first tests where with a serde serializer, which didn't really work out and I forgot to remove serde :( Removed serde and all the Serialize/Deserialize derives. >> + pub hello_interval: Option, >> + pub csnp_interval: Option, >> + pub hello_multiplier: Option, >> + pub is_ipv4: bool, >> + pub is_ipv6: bool, >> +} >> + >> +impl OpenfabricInterface { > >If the struct and its fields are all `pub` - why do we need/want getters? No reason. Removed all the setters/getters. >> + pub fn fabric_id(&self) -> &OpenfabricRouterName { >> + &self.fabric_id >> + } >> + pub fn passive(&self) -> Option { >> + self.passive >> + } >> + pub fn hello_interval(&self) -> Option { >> + self.hello_interval >> + } >> + pub fn csnp_interval(&self) -> Option { >> + self.csnp_interval >> + } >> + pub fn hello_multiplier(&self) -> Option { >> + self.hello_multiplier >> + } >> + pub fn set_hello_interval( >> + &mut self, >> + interval: impl Into>, >> + ) { >> + self.hello_interval = interval.into(); >> + } >> +} >> + >> [snip] Thanks for the review! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel