From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id EBDA81FF164
	for <inbox@lore.proxmox.com>; Fri,  8 Nov 2024 10:48:57 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id F1D78AA25;
	Fri,  8 Nov 2024 10:48:56 +0100 (CET)
Date: Fri, 8 Nov 2024 10:48:53 +0100
From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Message-ID: <j5ho54ryfisn2k2p3i2nkspjlwzmimac7rdlcgy3sv6ceguoo6@4ztafzt3hsmj>
References: <20241018115943.813243-1-c.heiss@proxmox.com>
 <20241018115943.813243-5-c.heiss@proxmox.com>
 <c41e3afc-de04-4f14-937f-6c8810b7fa25@proxmox.com>
 <6puwldfczbsxkh7etz5pn2dgyaaodt3yg6rxuafud3jeqv3cp4@7pfyraxjjpxq>
 <69f3c439-9e9c-4201-b046-b7cbf3884054@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <69f3c439-9e9c-4201-b046-b7cbf3884054@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer 4/4] fetch-answer: use partition
 label from fetch config instead of hardcoded
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Fri, Nov 08, 2024 at 10:30:18AM +0100, Aaron Lauterer wrote:
> On  2024-11-08  10:28, Christoph Heiss wrote:
> > [..]
> > Also, while reading this, seems nowhere is checked whether the
> > user-supplied value is at max 11 characters long -- I'll add that for v2
> > too.
>
> Too be honest, do we need to do that? For the default it is important, but
> users can use other FS that might allow for longer labels and if the kernel
> of the install live system can handle it, all is good.

Right, we aren't really constrained by FAT here! Thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel