From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0613B99242 for ; Tue, 10 Oct 2023 14:56:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2A2632FC8 for ; Tue, 10 Oct 2023 14:56:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Oct 2023 14:56:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5ED7D44786 for ; Tue, 10 Oct 2023 14:56:29 +0200 (CEST) Date: Tue, 10 Oct 2023 14:56:28 +0200 From: Christoph Heiss Cc: Proxmox VE development discussion , Filip Schauer , Thomas Lamprecht Message-ID: References: <20230804102646.34999-1-f.schauer@proxmox.com> <20230804102646.34999-2-f.schauer@proxmox.com> <2730c950-b0d7-45dc-af83-80ff808da9b7@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2730c950-b0d7-45dc-af83-80ff808da9b7@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.537 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment MISSING_HEADERS 1.021 Missing To: header SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2023 12:56:31 -0000 On Tue, Oct 10, 2023 at 01:55:43PM +0200, Thomas Lamprecht wrote: > > Am 10/10/2023 um 13:33 schrieb Christoph Heiss: > > On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote: > >> @@ -347,7 +347,7 @@ sub create_ipconf_view { > >> > >> my $get_device_desc = sub { > >> my $iface = shift; > >> - return "$iface->{name} - $iface->{mac} ($iface->{driver})"; > >> + return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}"; > > > > I think it would be better to only show the state if the interface is > > actually UP - thus drawing immediate attention to these list entries and > > not completely overloading that dropdown. > > > > Maybe even append it as "(UP)" instead of by dash (as it does not really > > identify the interface, but rather is a property of it). > > > > Or, if the GTK component and available fonts support it we could also use > unicode I like the idea! > > UP -> 🟢 https://unicode-explorer.com/c/1F7E2 A green circle would be problematic/non-optimal for people deuteranopia (red-green color blindness). So maybe some other character/symbol distinctly recognizable as "being connected, up" - but purely color-coding things is not something that should be done IMO. > DOWN -> ◯ (preferred, easier to differ for vision impaired people) or ⬤ > https://unicode-explorer.com/c/25EF or https://unicode-explorer.com/c/2B24 Do we really need to explicitly mark non-UP interfaces? I'd think the fact of it being not marked UP should provide enough context in this situation. > > Would use less space and probably look better, if it works that is ^^