From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B54DD1FF164 for ; Fri, 6 Dec 2024 11:40:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E12B2EE9; Fri, 6 Dec 2024 11:40:36 +0100 (CET) Date: Fri, 6 Dec 2024 11:40:02 +0100 From: Gabriel Goller To: Lukas Wagner Message-ID: References: <20241206101007.156910-1-l.wagner@proxmox.com> <20241206101007.156910-2-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241206101007.156910-2-l.wagner@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > fn main() { >- if let Err(err) = syslog::init( >- syslog::Facility::LOG_DAEMON, >- log::LevelFilter::Info, >- Some("proxmox-mail-forward"), >- ) { >+ if let Err(err) = proxmox_log::init_logger("PROXMOX_LOG", LevelFilter::INFO) { > eprintln!("unable to initialize syslog: {err}"); > } > Haven't looked at this crate yet, so I don't know where it's all used, but IMO the new `init_perlmod_logger` would be better? Because the `init_logger` function will always print to journald and check if a pbs task exists (which will never happen here afaiu). We can also add another simpler subscriber which will only log to journald (I can also do that, just let me know). Btw now I release how stupid these function names are, I should rename them in the future eliding the `perlmod`, `cli` names. Something like `init_journald_and_tasks` and `init_stderr_and_journald`. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel