From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8517E1FF168 for ; Tue, 12 Nov 2024 11:33:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DB7151D55B; Tue, 12 Nov 2024 11:33:57 +0100 (CET) Date: Tue, 12 Nov 2024 11:33:54 +0100 From: Christoph Heiss To: Thomas Lamprecht Message-ID: References: <20241111131519.867887-1-c.heiss@proxmox.com> <00019f8d-e4f2-420e-892a-b89e8b886748@proxmox.com> MIME-Version: 1.0 Content-Disposition: attachment In-Reply-To: <00019f8d-e4f2-420e-892a-b89e8b886748@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH installer v4 00/12] fix #5536: implement post-(auto-)installation notification mechanism X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, Nov 11, 2024 at 06:41:15PM +0100, Thomas Lamprecht wrote: > Am 11.11.24 um 14:14 schrieb Christoph Heiss: > > This implements a mechanism for post-installation "notifications" via a > > POST request [0] when using the auto-installer. > > [..] > > Feedback on the post-hook information schema is of course also very much > > appreciated! > > What about adding an X.Y format version? So that we can expand this nicely or > even rework completely. > [..] > One naturally can use the product version for deriving the format version, > but in the long run that needs more client side handling and mapping than > a separate format version. Sure, makes sense! The document format will surely change/get expanded in the future, so definitely good to have something like this from the get-go. I'll send a patch asap, fairly trivial to implement for now anyway. > > > > > It should be noted that some information like DMI is generally very > > depended on the motherboard/firmware, on what information is actually > > available and filled-in. So the contents are expected to vary wildly > > between machines and may also be empty, as in the example below from a > > VM. > > Can we also dump the schema so that this can be added to the docs, or > at least (linked to) in the wiki of the automated installer? Of course! Glancing over it, the schema for the JSON that `proxmox-fetch-answer` is also not explicitly documented - so I'll that one too. > > Also, I figure you already planned to document this in the wiki for the > next ISO release? Just asking to be sure it won't be overlooked. Yes! Just waited for this to get applied, i.e. having a finalized format. > > > > > Diffstat > > ======== > > > > Christoph Heiss (12): > > debian: strip unused library dependencies > > fetch-answer: move http-related code to gated module in > > installer-common > > tree-wide: convert some more crates to use workspace dependencies > > auto-install-assistant: replace `PathBuf` parameters with > > `AsRef` > > ^- this one would have done well with some short commit message body, > even if obvious it will never hurt to state the intention of the commit. Ack! > > > auto-installer: tests: simplify empty disks check > > auto-installer: tests: replace `PathBuf` parameters with `AsRef` > > ^- same here w.r.t. the lack of a short commit message body > > > auto-installer: move `SystemDMI` struct to common crate > > auto-installer: answer: factor out answer file reading into function > > auto-installer: udevinfo: introduce type alias for udev properties > > fix #5536: auto-installer: answer: add `posthook` section > > fix #5536: post-hook: add utility for sending notifications after > > auto-install > > ^- above two might have been better off squashed, but I can get how you > wanted to separate them, so I kept them as is. Thanks! Since the second patch, adding the `proxmox-post-hook` tool, was pretty big already, I'd tried to split off things not immediately relevant to it. (In a sense that the tool is considered "standalone") _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel