From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 265931FF15C
	for <inbox@lore.proxmox.com>; Wed,  8 Jan 2025 15:28:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 66C391BB28;
	Wed,  8 Jan 2025 15:28:18 +0100 (CET)
Date: Wed, 8 Jan 2025 15:28:14 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Message-ID: <gypihjhsnctiomyqyzsl4k4zphidc5r3drpray6pyh4scqz52a@dgpkyjnswgrg>
References: <20250108093314.33490-1-g.goller@proxmox.com>
 <20250108093314.33490-3-g.goller@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250108093314.33490-3-g.goller@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.032 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v3 2/3] guest: refactor and reuse
 AgentIPView for containers
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 08.01.2025 10:33, Gabriel Goller wrote:
>     updateStatus: function(unsuccessful, defaulttext) {
> 	var me = this;
>-	var text = defaulttext || gettext('No network information');
>-	var more = false;
>-	if (unsuccessful) {
>-	    text = gettext('Guest Agent not running');
>-	} else if (me.agent && me.running) {
>-	    if (Ext.isArray(me.nics) && me.nics.length) {
>-		more = true;
>-		var ips = me.getDefaultIps(me.nics);
>-		if (ips.length !== 0) {
>-		    text = ips.join('<br>');
>-		}
>-	    } else if (me.nics && me.nics.error) {
>-		text = Ext.String.format(text, me.nics.error.desc);
>-	    }
>-	} else if (me.agent) {
>-	    text = gettext('Guest Agent not running');
>-	} else {
>-	    text = gettext('No Guest Agent configured');
>-	}
>
>-	var ipBox = me.down('#ipBox');
>+	me.updateStatusCallback(me, unsuccessful, defaulttext);
>+
>+	var ipBox = ipview.down('#ipBox');
> 	ipBox.update(text);
>
>-	var moreBtn = me.down('#moreBtn');
>+	var moreBtn = ipview.down('#moreBtn');
> 	moreBtn.setVisible(more);

Oops, this hunk shouldn't be here, sent a v4 fixing it!



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel