From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 915711FF13F for ; Thu, 26 Mar 2026 15:15:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10FA115086; Thu, 26 Mar 2026 15:15:24 +0100 (CET) Date: Thu, 26 Mar 2026 15:14:48 +0100 From: Arthur Bied-Charreton To: Fiona Ebner Subject: Re: [PATCH pve-manager 2/8] ui: CPUModelSelector: Fix dirty state on default Message-ID: References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-3-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774534440536 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.807 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LKYONLGUY7F2XMTE7NJW6EGCJVHXH2S6 X-Message-ID-Hash: LKYONLGUY7F2XMTE7NJW6EGCJVHXH2S6 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 26, 2026 at 10:53:01AM +0100, Fiona Ebner wrote: > Am 12.03.26 um 9:40 AM schrieb Arthur Bied-Charreton: > > 'originalValue' is set to null in case it's the default, but getValue > > returns an empty string. This means that when editing a VM's CPU config > > when the model is 'default', the form would always be marked dirty. > > > > Original patch: > > https://lore.proxmox.com/pve-devel/20211028114150.3245864-7-s.reiter@proxmox.com/ > > > > I wonder if this is (still) needed? If I remove the getValue() function, > and instead add the following in www/manager6/form/CPUModelSelector.js > > setValue: function (value) { > > let me = this; > > me.callParent([value]); > > console.log('val: ' + value + ' dirty: ' + me.isDirty()); > > }, > > > for debugging, it doesn't seem to be dirty when the default is set. > You're right, I cannot reproduce it either. Dropping this in the next iteration. [...]