From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AEB0B1FF13C for ; Thu, 02 Apr 2026 15:58:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 362F41BCE9; Thu, 2 Apr 2026 15:59:14 +0200 (CEST) Date: Thu, 2 Apr 2026 15:58:37 +0200 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [RFC manager/network/proxmox{,-ve-rs,-perl-rs} v2 00/25] Add WireGuard as protocol to SDN fabrics Message-ID: Mail-Followup-To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260402081148.76276-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260402081148.76276-1-s.hanreich@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775138259299 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GLS5HZUEOCF5ITQYXRR77PODBYVVIZU2 X-Message-ID-Hash: GLS5HZUEOCF5ITQYXRR77PODBYVVIZU2 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Will have a look at the code later, but some high-level (mostly ui) stuff in the meantime: * when deleting a node referenced as a peer by another node, one gets this confusing message: "deleting node failed: peer configuration references non-existing interface (500)" (maybe include which node uses the peer) * "Endpoint" is a bit confusing, maybe add a tooltip or default text (same on "Allowed IPs") * maybe a nicer error message when the first wg command (wg genkey) fails (mention that wireguard-tools has to be installed) * would it be possible (and sensible) that a peer is autoselected so bidirectional traffic is possible by default. e.g. when creating a node and adding a peer, the new node is added as a peer in the existing nodes (which have been selected as peers from the new node). Otherwise it's quite exhausting right now adding a new node, selecting all the peers and then needing to go through and edit all the other existing nodes and checking the newly added peer. Of course it's maybe a bit magicky, but at least it improves the usability? * when generating the ifupdown2 config, a newline above `auto wg0` would be nice. * when setting an ipv6 address we need to add a warning "enable ipv6 forwarding globally" like in the other fabrics. The rest works flawlessly, nice work!