From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15FDA9390D for ; Thu, 5 Jan 2023 14:59:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 689D73A6E for ; Thu, 5 Jan 2023 14:59:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 5 Jan 2023 14:59:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 54F3A44336 for ; Thu, 5 Jan 2023 14:59:38 +0100 (CET) Message-ID: Date: Thu, 5 Jan 2023 14:59:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner , c.ebner@proxmox.com References: <20230105091804.156599-1-c.ebner@proxmox.com> <20230105091804.156599-2-c.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.433 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.939 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2023 13:59:43 -0000 Am 05/01/2023 um 14:51 schrieb Fiona Ebner: >> + my($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log", >> + $param->{start}, $param->{limit}, undef, $param->{since}, $param->{until}); > Style nit: please use 1 line for each parameter if it gets too long [1] > In general we try to adhere to rustfmt style, at least in spirit as not everything can be mapped to perl. That format has an intermediate step between one arg per line namely something like: PVE::Tools::foo( $bar, $baz, $very_long_argument_bla_bla) Here, that might still work out if we pull out the $param stuff first, e.g.:: my ($start, $limit, $since, $until) = param->@{qw(start limit since until)}; PVE::Tools::dump_fw_logfile( "/var/log/pve-firewall.log", $start, $limit, undef, $since, $until)