From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4766FFCB9 for ; Mon, 24 Jul 2023 16:09:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1ECA5FCA9 for ; Mon, 24 Jul 2023 16:09:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 16:09:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 622FD43ABF for ; Mon, 24 Jul 2023 16:09:23 +0200 (CEST) Message-ID: Date: Mon, 24 Jul 2023 16:09:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com References: <20230720143236.652292-1-l.wagner@proxmox.com> <20230720143236.652292-56-l.wagner@proxmox.com> From: Lukas Wagner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 pve-manager 55/69] api: notification: disallow removing targets if they are used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 14:09:54 -0000 On 7/24/23 15:50, Wolfgang Bumiller wrote: >> +sub target_used_by { >> + my ($target) = @_; >> + >> + my $used_by = []; >> + >> + # Check keys in datacenter.cfg >> + my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg'); >> + for my $key (qw(target-package-updates target-replication target-fencing)) { >> + if ($dc_conf->{notify} && $dc_conf->{notify}->{$key} eq $target) { >> + push @$used_by, $key; >> + } >> + } >> + >> + # Check backup jobs >> + my $jobs_conf = PVE::Cluster::cfs_read_file('jobs.cfg'); > > I'm not exactly a big fan of requiring a function to know all the places > that might declare notification targets, but I suppose for now this is > "good enough". > > If more of these get added we might need a better way, for instance we > could give other packages a way to register callbacks to collect this > information... > Yes, I plan to implement a 'notification sender registry' at some point, I think your suggestion could be integrated there quite nicely. Thanks! -- - Lukas