From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C82696917D for ; Mon, 22 Mar 2021 09:56:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC8E021026 for ; Mon, 22 Mar 2021 09:56:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 14BA22101C for ; Mon, 22 Mar 2021 09:56:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C9EED46269 for ; Mon, 22 Mar 2021 09:56:18 +0100 (CET) To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20210319134908.10558-1-f.ebner@proxmox.com> <20210319134908.10558-2-f.ebner@proxmox.com> <1616162913.ti6lv8kl41.astroid@nora.none> From: Fabian Ebner Message-ID: Date: Mon, 22 Mar 2021 09:56:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1616162913.ti6lv8kl41.astroid@nora.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.397 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 2/3] migrate: always check if content type images is available for target storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 08:56:52 -0000 Am 19.03.21 um 15:16 schrieb Fabian Grünbichler: > On March 19, 2021 2:49 pm, Fabian Ebner wrote: >> it's cheap and saves code. > > but also changes behaviour in a non-backwards-compatible fashion. > > previously, if a disk was already on a storage that does not have images > configured, and the migration leaves it on that storage, this config > mismatch was ignored (hence the "grandfather in existing mismatches" > comment). note that users might be able to migrate, but not able to > change storage.cfg to fix this "misconfiguration". > What about the recent change [0] in pve-storage then, i.e. not listing VM disks for storages without an appropriate content type? I'd argue that unreferenced images that lie on storages without an 'image' content type should not be picked up in the first place. If we don't agree on this, then [0] needs to be reverted... If we do agree on this, we should double down on [0] and actually be precise about the content type in vdisk_list by either: A) adding a content/guest type parameter to vdisk_list. B) adapting the call sites to filter storages. Afterwards, this patch could be applied with the appropriate dependency bump ;) Note that referenced unused images will still be picked up by the PVE::QemuServer::foreach_volid iteration, no matter what the content type of their storage is. [0]: https://git.proxmox.com/?p=pve-storage.git;a=commit;h=a44c18925d223a971296801a0985db34707ada4d >> >> Signed-off-by: Fabian Ebner >> --- >> PVE/QemuMigrate.pm | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm >> index 3597cc9..44cecce 100644 >> --- a/PVE/QemuMigrate.pm >> +++ b/PVE/QemuMigrate.pm >> @@ -410,11 +410,8 @@ sub sync_disks { >> $log_error->("storage '$targetsid' is not available on node '$self->{node}'") >> if !$target_scfg; >> >> - # grandfather in existing mismatches >> - if ($targetsid ne $storeid && $target_scfg) { >> - $log_error->("content type 'images' is not available on storage '$targetsid'") >> - if !$target_scfg->{content}->{images}; >> - } >> + $log_error->("content type 'images' is not available on storage '$targetsid'") >> + if $target_scfg && !$target_scfg->{content}->{images}; >> >> PVE::Storage::foreach_volid($dl, sub { >> my ($volid, $sid, $volinfo) = @_; >> -- >> 2.20.1 >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >