From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4F3DD92085 for ; Fri, 16 Feb 2024 15:42:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EFAC4092 for ; Fri, 16 Feb 2024 15:42:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Feb 2024 15:42:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4668D48564 for ; Fri, 16 Feb 2024 15:42:19 +0100 (CET) Message-ID: Date: Fri, 16 Feb 2024 15:42:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20231121124732.2803365-1-d.csapak@proxmox.com> <20231121124732.2803365-4-d.csapak@proxmox.com> From: Fiona Ebner In-Reply-To: <20231121124732.2803365-4-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v2 1/1] ui: implement 'Tag View' for the resource tree X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2024 14:42:20 -0000 Am 21.11.23 um 13:47 schrieb Dominik Csapak: > and keep the functionality in ResourceTree as generic as possible. > > We achieve this by having an 'itemMap' function that can split one item > from the store into multiple to add to the tree. > > for the updates, we have to have an 'idMapFn' (to get the original id > back) > > we also have to modify how the move checks work a bit, since we only > want to move the items when the tags changed only in the tagview case > > in the ResourceGrid we have to get the id a bit differently since we now > have 'virtual' ids for the entries tag contain the tag (which can't be > found in the resource store) > > since we also don't want tooltips for the already expanded tag groups, > we have to add the special condition that the element directly above > the tag should not have the 'full' class (like it is in tag group case) > > Signed-off-by: Dominik Csapak No real issues found during testing, but there is one thing that bugs me: if I have selected a guest either: - without tags and add a tag or - within the current tag group and remove that tag then the selections for the guest is lost. Since it's the selection in the resource view, this also affects the main area as a consequence and feels a bit disruptive. > @@ -530,7 +531,7 @@ Ext.define('PVE.StdWorkspace', { > let tagSelectors = []; > ['circle', 'dense'].forEach((style) => { > ['dark', 'light'].forEach((variant) => { > - tagSelectors.push(`.proxmox-tags-${style} .proxmox-tag-${variant}`); > + tagSelectors.push(`.proxmox-tags-${style} :not(.proxmox-tags-full) > .proxmox-tag-${variant}`); eslint fails because the line is too long > }); > }); >