From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E80BC1FF2AA for ; Wed, 3 Jul 2024 14:26:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D43987829; Wed, 3 Jul 2024 14:26:41 +0200 (CEST) Message-ID: Date: Wed, 3 Jul 2024 14:26:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20240610090415.13057-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240610090415.13057-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.312 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH storage] volume import: assume target API version is at least 9 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.06.24 um 11:04 schrieb Fiona Ebner: > The storage API version has been bumped to at least 9 since > libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where > this change will come in, then the target node can be assumed to be > running either Proxmox VE 8 or, during upgrade, the latest version of > Proxmox VE 7.4, so it's safe to assume a storage API version of at > least 9 in all cases. > > As reported by Maximiliano, the fact that the 'apiinfo' call was > guarded with a quiet eval could lead to strange errors for replication > on a customer system where an SSH connection could not always be > established, because the target's API version would fall back to 1. > Because of that, the '-base' argument would be missing for the import > call on the target which would in turn lead to an error about the > target ZFS volume already existing (rather than doing an incremental > sync). > > Reported-by: Maximiliano Sandoval > Signed-off-by: Fiona Ebner applied, with Max's R-b, thanks for that! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel