From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E421660747 for ; Wed, 9 Sep 2020 21:09:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE93A14009 for ; Wed, 9 Sep 2020 21:09:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6E4FA13FFC for ; Wed, 9 Sep 2020 21:09:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3BAF344ADA for ; Wed, 9 Sep 2020 21:09:51 +0200 (CEST) To: Proxmox VE development discussion , Fabian Ebner Cc: Wolfgang Bumiller References: <20200908115843.345-1-f.ebner@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Wed, 9 Sep 2020 21:09:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200908115843.345-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.188 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [monitor.pm] Subject: [pve-devel] applied-series: [PATCH v2 container 1/2] Add module for reading state changes from monitor socket X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 19:09:51 -0000 On 08.09.20 13:58, Fabian Ebner wrote: > Will be used to monitor state changes on container startup. > > Co-developed-by: Wolfgang Bumiller > Signed-off-by: Fabian Ebner > --- > > New in v2. > > I hard-coded the name of the abstract UNIX socket instead of > trying to re-implement lxc/monitor.c's lxc_monitor_sock_name > function. For us, is it true that the lxcpath is always '/varl/lib/lxc'? > Otherwise this won't always work. > > src/PVE/LXC/Makefile | 1 + > src/PVE/LXC/Monitor.pm | 92 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 93 insertions(+) > create mode 100644 src/PVE/LXC/Monitor.pm > > applied series, thanks! Wolfgang may improve his variant, e.g., by patching lxc, to avoid a runtime dependency on the lxc monitor, but until that works out this is 10000x times better that the current status quo.