From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 980EC91F8E for ; Wed, 31 Jan 2024 14:53:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 80B1A3B724 for ; Wed, 31 Jan 2024 14:53:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 31 Jan 2024 14:53:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C3DCF4909F for ; Wed, 31 Jan 2024 14:53:32 +0100 (CET) Message-ID: Date: Wed, 31 Jan 2024 14:53:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Markus Frank , Proxmox VE development discussion References: <20231108085254.53574-1-m.frank@proxmox.com> <20231108085254.53574-3-m.frank@proxmox.com> <38d62435-50ed-48ac-96f5-932e2be9e2c7@proxmox.com> From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2024 13:53:33 -0000 Am 31.01.24 um 14:42 schrieb Markus Frank: >> >> I haven't looked at the code where this is used yet, so I'm as confused >> as a user now ;) Does this affect mount points within the directory >> (which the "sub" prefix suggests)? But it's a boolean, so how can I tell >> "which directories"? The description should answer: When does it need to >> be set/what effect does it have? > I do not know why I wrote it like that. > > This is more correct: >     description => "Announce that the directory contains other mounted > file systems.", > What happens if there are nested mounts, but the flag is not set? Will the directory be mounted without the nested mounts or will it fail? This should be made clear to users. >> >> What could also be mentioned for xattr and acl: do the underlying file >> systems need to support these? What happens if they don't? > ACLs and xattrs just get ignored if not supported. Please include that in the description, thanks!