From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81CB3FAF8 for ; Mon, 24 Jul 2023 13:46:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62A10DB2F for ; Mon, 24 Jul 2023 13:46:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 13:46:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6868443AF6 for ; Mon, 24 Jul 2023 13:46:11 +0200 (CEST) Message-ID: Date: Mon, 24 Jul 2023 13:46:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: pve-devel@lists.proxmox.com References: <20230313125625.1060320-1-f.weber@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20230313125625.1060320-1-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.208 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.093 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server] fix: api: fix permission check for cloudinit drive update X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 11:46:12 -0000 ping (patch still applies) On 13/03/2023 13:56, Friedrich Weber wrote: > Trying to regenerate a cloudinit drive as a non-root user via the API > currently throws a Perl error, as reported in the forum [1]. This is > due to a type mismatch in the permission check, where a string is > passed but an array is expected. > > [1] https://forum.proxmox.com/threads/regenerate-cloudinit-by-put-api-return-500.124099/ > > Signed-off-by: Friedrich Weber > --- > To see if we have the same problem for other API endpoints, I ran: > grep -r "['\"]perm['\"][^[]*]" . > in my locally checked-out repos, but found only this single occurrence. > > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 587bb22..0ea18eb 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1398,7 +1398,7 @@ __PACKAGE__->register_method({ > proxyto => 'node', > description => "Regenerate and change cloudinit config drive.", > permissions => { > - check => ['perm', '/vms/{vmid}', 'VM.Config.Cloudinit'], > + check => ['perm', '/vms/{vmid}', ['VM.Config.Cloudinit']], > }, > parameters => { > additionalProperties => 0,