From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DB8C41FF37F for ; Thu, 18 Apr 2024 17:47:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 612373072D; Thu, 18 Apr 2024 17:47:11 +0200 (CEST) Message-ID: From: Alexander Zeidler To: Proxmox VE development discussion Date: Thu, 18 Apr 2024 17:46:37 +0200 In-Reply-To: <76e37339-f31e-4660-b7fe-e23d96840e59@proxmox.com> References: <20240418091650.51366-1-a.zeidler@proxmox.com> <76e37339-f31e-4660-b7fe-e23d96840e59@proxmox.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 2024-04-18 at 13:05 +0200, Mira Limbeck wrote: > On 4/18/24 11:16, Alexander Zeidler wrote: > > to get a first clue for debugging passthrough and similar issues, when > > no dmesg output has been provided yet. > > > > Signed-off-by: Alexander Zeidler > > --- > > v2: > > * move away from dmesg base > > * only print kernel command line (boot times can be added by another patch) > > > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062342.html > > > > > > PVE/Report.pm | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/PVE/Report.pm b/PVE/Report.pm > > index 53ffdcbb..a8c1cab9 100644 > > --- a/PVE/Report.pm > > +++ b/PVE/Report.pm > > @@ -31,6 +31,7 @@ my $init_report_cmds = sub { > > cmds => [ > > 'hostname', > > 'date -R', > > + 'cat /proc/cmdline', > > 'pveversion --verbose', > > 'cat /etc/hosts', > > 'pvesubscription get', > Tested the whole patch series. > Looks good so far, especially the cmdline and APT information is nice to > have. > > With the added APT information between subscription info, lscpu and > /cluster/resources, would it maybe make sense to move `pvesubscription > get` and `pvesh get /cluster/resources` next to each other, Good idea. > and `lscpu` > to the hardware section where we have all the `dmidecode` output, and > `lspci`? Maybe placing `lscpu` above or below the potentially accepted (compact version) of the new memory output? I think it makes sense to start with the mainboard, followed by cpu/memory and ending with the extensive `lspci`. The move of `lscpu` was already discussed in v1 here: [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections https://lists.proxmox.com/pipermail/pve-devel/2024-April/062871.html but I decided to drop it since it was related to another now dropped change. > Except for the `dmidecode -t16,17` command needing a space for > consistency, I'm fine with any of the additions. > So consider the whole series: > > Reviewed-by: Mira Limbeck > Tested-by: Mira Limbeck _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel