From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6396960B94 for ; Tue, 11 Jan 2022 16:45:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 537DA20C3B for ; Tue, 11 Jan 2022 16:45:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A3CF120C2B for ; Tue, 11 Jan 2022 16:45:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 695F146B6C for ; Tue, 11 Jan 2022 16:45:46 +0100 (CET) Message-ID: Date: Tue, 11 Jan 2022 16:45:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-US To: Proxmox VE development discussion , Stoiko Ivanov References: <20220111153936.229984-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220111153936.229984-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH zfsonlinux] cherry-pick lock-inversion patch for zvol_open X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 15:45:48 -0000 On 11.01.22 16:39, Stoiko Ivanov wrote: > the changes to zvol_open added to 2.1.2 (for coping with kernel > changes in 5.13) seem to have introduced a lock order inversion [0]. > > (noticed while reviewing the 2.0.6->2.0.7 changes (the patch was > applied after 2.1.2 was already tagged) > > [0] https://github.com/openzfs/zfs/pull/12863 > Signed-off-by: Stoiko Ivanov > --- > did not reproduce the dead-lock myself (in my very limited tests) > but given that our 2.1.2 packages (and kernel modules) have not seen > too much testing in public yet - thought it makes sense to proactively > pull this in > > quickly tested a kernel+userspace with this patch on a physical testhost > > .../0012-Fix-zvol_open-lock-inversion.patch | 212 ++++++++++++++++++ > debian/patches/series | 1 + > 2 files changed, 213 insertions(+) > create mode 100644 debian/patches/0012-Fix-zvol_open-lock-inversion.patch > > applied, thanks!