From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C8F861FF186 for ; Tue, 5 Nov 2024 16:49:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8C99633097; Tue, 5 Nov 2024 16:49:46 +0100 (CET) Message-ID: Date: Tue, 5 Nov 2024 16:49:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Severen Redwood , pve-devel@lists.proxmox.com References: <20241105020054.215734-1-severen.redwood@sitehost.co.nz> <20241105020054.215734-3-severen.redwood@sitehost.co.nz> From: Aaron Lauterer In-Reply-To: <20241105020054.215734-3-severen.redwood@sitehost.co.nz> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container v3] api: record CT ID as used after a container is destroyed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: t.lamprecht@proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" beside one small nit that could be cleaned up in a follow-up, consider this: Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-11-05 03:00, Severen Redwood wrote: > After a container is destroyed, record that its ID has been used via the > `PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can > later optionally avoid suggesting previously used IDs. > > Co-authored-by: Daniel Krambrock > Signed-off-by: Severen Redwood > --- > Changed since v2 is the addition of the use statement for `PVE::UsedVmidList`. > > src/PVE/API2/LXC.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm > index 213e518..cc47c5c 100644 > --- a/src/PVE/API2/LXC.pm > +++ b/src/PVE/API2/LXC.pm > @@ -28,6 +28,7 @@ use PVE::API2::LXC::Config; > use PVE::API2::LXC::Status; > use PVE::API2::LXC::Snapshot; > use PVE::JSONSchema qw(get_standard_option); > +use PVE::UsedVmidList qw(add_vmid); adding the `qw(add_vmid)` here is not strictly necessary, AFAIU. We call the function with the full PVE::UsedVmidList:: prefix anyway. > use base qw(PVE::RESTHandler); > > BEGIN { > @@ -794,7 +795,9 @@ __PACKAGE__->register_method({ > } > } > > - # only now remove the zombie config, else we can have reuse race > + # only now mark the CT ID as previously used and remove the zombie > + # config, else we can have reuse race > + PVE::UsedVmidList::add_vmid($vmid); > PVE::LXC::Config->destroy_config($vmid); > }; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel