From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AD5C91FF137 for ; Tue, 31 Mar 2026 18:15:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E5CA293A; Tue, 31 Mar 2026 18:16:18 +0200 (CEST) Message-ID: Date: Tue, 31 Mar 2026 18:16:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage To: Kefu Chai , pve-devel@lists.proxmox.com References: <20260331071041.1199091-1-k.chai@proxmox.com> <20260331071041.1199091-4-k.chai@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260331071041.1199091-4-k.chai@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774973717896 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.506 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CESOQNB3SCWWCJS76HNPBN4CJDJHSY34 X-Message-ID-Hash: CESOQNB3SCWWCJS76HNPBN4CJDJHSY34 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 31.03.26 um 09:10 schrieb Kefu Chai: > Add override_dh_auto_test to debian/rules so that make test is > automatically executed during every package build, ensuring the > schema and Makefile consistency checks are enforced at build time. This already happens though? dh_auto_test will already trigger any "check" or "test" target if there's a Makefile present, and when building a package without your patch here I can see that working. Or am I missing something here? > > Signed-off-by: Kefu Chai > --- > debian/rules | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/debian/rules b/debian/rules > index f00dbc2..2118ffa 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -5,3 +5,6 @@ > > %: > dh $@ > + > +override_dh_auto_test: > + $(MAKE) -C . -f Makefile test