From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2DC338D981 for ; Wed, 9 Nov 2022 09:38:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04DF619922 for ; Wed, 9 Nov 2022 09:38:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 09:38:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D086C422A0 for ; Wed, 9 Nov 2022 09:38:02 +0100 (CET) Message-ID: Date: Wed, 9 Nov 2022 09:38:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20220920125041.3636561-1-d.csapak@proxmox.com> <20220920125041.3636561-8-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220920125041.3636561-8-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sysfstools.pm] Subject: Re: [pve-devel] [PATCH common v3 1/3] SysFSTools: make mdev cleanup independent of pciid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 08:38:35 -0000 Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > mediated devices also appear under /sys/bus/mdev/devices with their > uuid, independent of the pci device, so we can use that instead > > Signed-off-by: Dominik Csapak > --- > src/PVE/SysFSTools.pm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm > index b4cd5cc..b95e934 100644 > --- a/src/PVE/SysFSTools.pm > +++ b/src/PVE/SysFSTools.pm > @@ -367,11 +367,9 @@ sub pci_create_mdev_device { > } > > sub pci_cleanup_mdev_device { > - my ($pciid, $uuid) = @_; > + my ($uuid) = @_; > > - $pciid = normalize_pci_id($pciid); > - > - my $basedir = "$pcisysfs/devices/$pciid/$uuid"; > + my $basedir = "/sys/bus/mdev/devices/$uuid"; > > if (! -e $basedir) { > return 1; # no cleanup necessary if it does not exist this is a breaking change for older qemu-server I'd like to avoid, meh why ain't such relations not encoded in the actual patch diff-comment area? Re-reading the cover letter each time for every 20 patches is rather a nuisance and really easy to overlook..