From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2F13B1FF164 for <inbox@lore.proxmox.com>; Wed, 25 Sep 2024 13:43:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C66371F301; Wed, 25 Sep 2024 13:43:40 +0200 (CEST) Date: Wed, 25 Sep 2024 13:43:07 +0200 From: Christoph Heiss <c.heiss@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <fcmqjwrpckxbknbpjiolfhvc5m6zh4m4oiya3r26kkph5v2dwn@4lvltgnvw5f3> References: <20240813161538.1660140-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240813161538.1660140-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 0/5] fix #5250: add btrfs `compress` mount option support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Ping, still applies on latest master. On Tue, Aug 13, 2024 at 06:15:29PM GMT, Christoph Heiss wrote: > Fixes #5250 [0]. > > Pretty much as it says on the tin, this adds the `compress` mount option > for Btrfs much in the same way as the ZFS equivalent. > > W.r.t to the discussion in #5250 - `compress` is used. For a detailed > explanation, see patch #2. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5250 > > History > ======= > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063845.html > > Notable changes v1 -> v2: > * rebased on latest master > * squashed auto-installer tests into feature patch > > Diffstat > ======== > > Christoph Heiss (5): > fix #5250: install: config: add new `btrfs_opts` with `compress` > config option > fix #5250: install: write btrfs `compress` option to fstab > fix #5250: proxinstall: expose new btrfs `compress` option > fix #5250: tui: expose new btrfs `compress` option > fix #5250: auto-installer: expose new btrfs `compress` option > > Proxmox/Install.pm | 11 +++++- > Proxmox/Install/Config.pm | 15 ++++++++ > proxinstall | 15 ++++++++ > proxmox-auto-installer/src/answer.rs | 6 +++- > proxmox-auto-installer/src/utils.rs | 7 +++- > .../tests/resources/parse_answer/btrfs.json | 24 +++++++++++++ > .../tests/resources/parse_answer/btrfs.toml | 17 ++++++++++ > proxmox-installer-common/src/options.rs | 31 +++++++++++++++++ > proxmox-installer-common/src/setup.rs | 21 ++++++++++-- > proxmox-tui-installer/src/setup.rs | 2 ++ > proxmox-tui-installer/src/views/bootdisk.rs | 34 +++++++++++++------ > 11 files changed, 167 insertions(+), 16 deletions(-) > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs.json > create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs.toml > > -- > 2.44.0 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel