From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 062E36CA79 for <pve-devel@lists.proxmox.com>; Tue, 30 Mar 2021 18:57:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED5852D206 for <pve-devel@lists.proxmox.com>; Tue, 30 Mar 2021 18:57:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 359802D1B4 for <pve-devel@lists.proxmox.com>; Tue, 30 Mar 2021 18:57:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 05AA14597E for <pve-devel@lists.proxmox.com>; Tue, 30 Mar 2021 18:57:26 +0200 (CEST) Message-ID: <fcf988be-90b2-7038-2e3d-a086a9ccaf79@proxmox.com> Date: Tue, 30 Mar 2021 18:57:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com> References: <20210330155952.16389-1-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210330155952.16389-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] applied: [PATCH pve-qemu 1/2] add upstream fixes for qmp_block_resize X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 30 Mar 2021 16:57:58 -0000 On 30.03.21 17:59, Stefan Reiter wrote: > cherry-picked cleanly from 6.0 development tree, fixes an issue with > resizing RBD drives (and reportedly also on krbd or potentially other > storage backends) with iothreads. > > Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> > --- > > Reported here ff.: > https://forum.proxmox.com/threads/all-vms-locking-up-after-latest-pve-update.85397/post-380409 > > Posters could also reproduce this on krbd, for me it only occured on user-space > rbd. Nevertheless, this looks to be a hot smoking gun, especially since both > configs from the forum show iothread=1. > > > ...lock-Fix-locking-in-qmp_block_resize.patch | 42 +++++++ > ...x-deadlock-in-bdrv_co_yield_to_drain.patch | 118 ++++++++++++++++++ > debian/patches/series | 2 + > 3 files changed, 162 insertions(+) > create mode 100644 debian/patches/extra/0011-block-Fix-locking-in-qmp_block_resize.patch > create mode 100644 debian/patches/extra/0012-block-Fix-deadlock-in-bdrv_co_yield_to_drain.patch > > applied, thanks!