From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4925B72371 for ; Thu, 1 Jul 2021 13:39:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FAD3241C3 for ; Thu, 1 Jul 2021 13:39:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C9A8324277 for ; Thu, 1 Jul 2021 13:39:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9A3DA428E2 for ; Thu, 1 Jul 2021 13:39:13 +0200 (CEST) Message-ID: Date: Thu, 1 Jul 2021 13:38:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dietmar Maurer References: <20210630061007.3345396-1-dietmar@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210630061007.3345396-1-dietmar@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.558 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-access-control v2 0/5] add OpenId realms X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 11:39:44 -0000 On 30.06.21 08:10, Dietmar Maurer wrote: > Changes in v2: > - also check if user is expired (in check_user_enabled) > - always die with newline > - rename "user-attr" to "username-claim" > > > Dietmar Maurer (5): > check_user_enabled: also check if user is expired > add OpenId configuration > depend on libpve-rs-perl > api: implement openid API > implement OpenID autocreate user feature > > debian/control | 2 + > src/PVE/API2/AccessControl.pm | 60 ++------- > src/PVE/API2/Makefile | 3 +- > src/PVE/API2/OpenId.pm | 238 ++++++++++++++++++++++++++++++++++ > src/PVE/AccessControl.pm | 18 +-- > src/PVE/Auth/Makefile | 3 +- > src/PVE/Auth/OpenId.pm | 68 ++++++++++ > src/PVE/RPCEnvironment.pm | 49 +++++++ > 8 files changed, 378 insertions(+), 63 deletions(-) > create mode 100644 src/PVE/API2/OpenId.pm > create mode 100755 src/PVE/Auth/OpenId.pm > applied series, thanks! But I moved the second hunk: - if (defined(my $user_attr = $config->{'user-attr'})) { + if (defined(my $user_attr = $config->{'username-claim'})) { of patch 5/5 ("implement OpenID autocreate user feature") into the previous patch 4/5 ("api: implement openid API") and adapted the error message in that if/else chain, as it still talked about "user_attrs" from v1.