From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 69C5E1FF161
for <inbox@lore.proxmox.com>; Wed, 18 Dec 2024 15:05:59 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1185D1746F;
Wed, 18 Dec 2024 15:05:58 +0100 (CET)
Message-ID: <fc3ebb39-be43-4e4a-a089-2410051b0f48@proxmox.com>
Date: Wed, 18 Dec 2024 15:05:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pve-devel@lists.proxmox.com
References: <20241217154814.82121-1-f.ebner@proxmox.com>
<20241217154814.82121-7-f.ebner@proxmox.com>
Content-Language: en-US
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <20241217154814.82121-7-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.025 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [iscsiplugin.pm]
Subject: Re: [pve-devel] [PATCH v2 storage 06/10] iscsi plugin: support
volume export
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
I tested exporting a volume from an iSCSI storage.
First I installed Debian in a VM on a LUN and then exported the volume:
```
$ pvesm export tgtstorage:0.0.1.scsi-360000000000000000e00000000010001
raw+size output
3915055104 bytes (3.9 GB, 3.6 GiB) copied, 11 s, 356 MB/s
65472+0 records in
65472+0 records out
4290772992 bytes (4.3 GB, 4.0 GiB) copied, 12.0677 s, 356 MB/s
```
Then I imported the volume into a directory storage:
```
$ pvesm import local:117/vm-117-disk-0.raw raw+size output
```
Assigned the disk to a VM and it booted up just fine.
Trying to import into an iSCSI storage fails as expected:
```
$ pvesm import tgtstorage raw+size output
cannot import into volume 'tgtstorage'
```
Tested-by: Filip Schauer <f.schauer@proxmox.com>
On 17/12/2024 16:48, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> src/PVE/Storage/ISCSIPlugin.pm | 48 ++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
> index 6de7610..eb70453 100644
> --- a/src/PVE/Storage/ISCSIPlugin.pm
> +++ b/src/PVE/Storage/ISCSIPlugin.pm
> @@ -596,5 +596,53 @@ sub volume_has_feature {
> return undef;
> }
>
> +sub volume_export_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return () if defined($snapshot); # not supported
> + return () if defined($base_snapshot); # not supported
> + return () if $with_snapshots; # not supported
> + return ('raw+size');
> +}
> +
> +sub volume_export {
> + my (
> + $class,
> + $scfg,
> + $storeid,
> + $fh,
> + $volname,
> + $format,
> + $snapshot,
> + $base_snapshot,
> + $with_snapshots,
> + ) = @_;
> +
> + die "volume export format $format not available for $class\n" if $format ne 'raw+size';
> + die "cannot export volumes together with their snapshots in $class\n" if $with_snapshots;
> + die "cannot export an incremental stream in $class\n" if defined($base_snapshot);
> + die "cannot export a snapshot in $class\n" if defined($snapshot);
> +
> + my $file = $class->filesystem_path($scfg, $volname, $snapshot);
> + my $size;
> + run_command(['/sbin/blockdev', '--getsize64', $file], outfunc => sub {
> + my ($line) = @_;
> + die "unexpected output from /sbin/blockdev: $line\n" if $line !~ /^(\d+)$/;
> + $size = int($1);
> + });
> + PVE::Storage::Plugin::write_common_header($fh, $size);
> + run_command(['dd', "if=$file", "bs=64k", "status=progress"], output => '>&'.fileno($fh));
> + return;
> +}
> +
> +sub volume_import_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return ();
> +}
> +
> +sub volume_import {
> + die "volume import is not possible on iscsi storage\n";
> +}
>
> 1;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel