From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 18ACD9697; Wed, 8 Mar 2023 18:05:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE7D79CF5; Wed, 8 Mar 2023 18:04:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 8 Mar 2023 18:04:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED9CF45DF1; Wed, 8 Mar 2023 18:04:35 +0100 (CET) Message-ID: Date: Wed, 8 Mar 2023 18:04:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Stefan Sterz , pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com References: <20230308161840.2396113-1-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230308161840.2396113-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH widget-toolkit v1] Proxmox Dark Theme X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 17:05:07 -0000 Am 08/03/2023 um 17:18 schrieb Stefan Sterz: > this patch series aims to add support for a dark theme to all current > proxmox products. including: > > * proxmox virtual environment web gui & api viewer > * proxmox backup server gui & api viewer > * proxmox mail gateway gui, api viewer & (mobile) quarantine > > this patch series is split into several parts. the first concerns the > widget toolkit and adds the necessary files and adaptions needed > accross all three products. the other three parts integrate the new > dark theme into pve, pbs and pmg and also adds changes needed by each > product. > > part 1: widget toolkit > > the first commit adds styles that give the main gui a "dark" > appearance. this includes adjusting the icons and other images as > well as all backgrounds text and link colors. the second commit > removes certain hard-coded background colors that are set via js. > these don't behave properly in the dark theme and the gui behaves > properly without them, so they are removed. > > the third and fourth commit make it possible for charts and gauges to > switch their colors based on the current theme. the fifth commit adds > a theme switcher widget that allows switching the current theme and > then sets a cookie accordingly. > > the last commit is only relevant for the proxmox mail gateway and > enables the proposed "theme switcher" function. this allows users to > enable or disable a filter over the email preview in the quarantine. > if the filter is enabled the email will have it's brightness reduced > and the colors will be inverted. thus, plain text emails shouldn't > appear too bright > > part 2: proxmox virtual environment > > the first commit for pve adds the theme switcher to the gui, the > second adjusts the pveproxy template to properly handle the cookie > set by the theme switcher. the third removes unnecessary hard-coded > background colors and the forth add support for the charts used in > pve only. > > the fifth commit concern pve-docs and adds support for the dark theme > in the api viewer. > > part 3: proxmox backup server > > the commits for proxmox backup server first add the theme switcher, > then removes hard-coded backgrounds and finally add dark theme support > to the api viewer. > > part 4: proxmox mail gateway > > the first commit concerns the api and let's it handle cookie properly. > the next five commits adjust gui to first add a theme switcher, then > style the spam info grid, remove hard-coded white backgrounds, style > the hourly mail chart, and enable the dark mode in the mobile > quarantine. > > the second-to-last commit enables the theme switching mechanism for > the quarantine mail preview. this part could be dropped in favor of > extending the preview endpoint to add some styles to the preview that > handle a dark theme. this would have the added benefit of also working > in the mobile quarantine. > > the last commit for the mail gateway enables the dark theme in the api > viewer. > > Daniel Tschlatscher (2): > dark-theme: add initial version of the proxmox-dark theme > util/window/form: add a theme selector > > Stefan Sterz (4): > subscription/summary/backup: stop setting the background color > gauge widget: add support for a dark theme and dynamic theme switching > rrd chart: add support for the dark theme and dynamic theme switching > dark-theme: add support for the pmg quarantine theme toggle > After re-checking basic UI stuff and some general skim plus some more close spot checking of the changes - while there are some nits and surely some slightly bigger fixes to be done, this is definitively easier and quicker done as follow up, not re-sending the base of the series, so with that: applied, huge thanks to you and Daniel!