From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7FE5F9DC04 for ; Fri, 24 Nov 2023 17:09:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F191124F7 for ; Fri, 24 Nov 2023 17:09:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Nov 2023 17:09:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EB84143C72 for ; Fri, 24 Nov 2023 17:09:10 +0100 (CET) Message-ID: Date: Fri, 24 Nov 2023 17:08:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Lukas Wagner , Maximiliano Sandoval References: <20231124145815.179803-1-m.sandoval@proxmox.com> <9c20a776-1477-4510-a0c5-9563ee10b8c1@proxmox.com> From: Fiona Ebner In-Reply-To: <9c20a776-1477-4510-a0c5-9563ee10b8c1@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2023 16:09:42 -0000 Am 24.11.23 um 16:41 schrieb Lukas Wagner: > > > On 11/24/23 15:58, Maximiliano Sandoval wrote: >> -            Ext.String.format(gettext('No {0} repository is enabled, >> you do not get any updates!'), vm.get('product')), >> +            Ext.String.format(gettext('No {0} repository is enabled, >> you would not get any updates!'), vm.get('product')), > > The long form of won't is 'will not', not 'would not'. 'will not' also > seems more appropriate here. > Both wordings are correct, just a different tense You do not get any updates (i.e. right now) You will not get any updates (i.e. in the future) Is there a good reason for changing it in the first place? Should be mentioned in the commit message then ;)