From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH http-server 1/2] add error message into http body
Date: Mon, 27 Jan 2025 13:44:34 +0100 [thread overview]
Message-ID: <fa580fc3-7b05-403b-b9f4-9c6d427e510a@proxmox.com> (raw)
In-Reply-To: <f838efc6-fcbc-41b7-b391-8d5c49b32d9f@proxmox.com>
any new input on this?
I have thought about blindly adding 'plain/text' to it or do an 'encode_json("$msg")' and adding
'application/json', but both options don't seem very sensible to me, as they're altering
the content type for all errors the api returns. This might trip up some clients.
(whereas before we did not set it so the client was free to guess or ignore the body content,
even if it was set)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-27 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 8:45 [pve-devel] [RFC PATCH http-server 0/2] improve error handling on api errors Dominik Csapak
2025-01-08 8:45 ` [pve-devel] [RFC PATCH http-server 1/2] add error message into http body Dominik Csapak
2025-01-15 16:08 ` Thomas Lamprecht
2025-01-16 7:31 ` Dominik Csapak
2025-01-27 12:44 ` Dominik Csapak [this message]
2025-01-28 14:24 ` Thomas Lamprecht
2025-01-28 14:46 ` Dominik Csapak
2025-01-29 17:51 ` Thomas Lamprecht
2025-01-08 8:45 ` [pve-devel] [RFC PATCH http-server 2/2] use HTTP_INTERNAL_SERVER_ERROR were appropriate instead of '501' Dominik Csapak
2025-01-15 16:19 ` Thomas Lamprecht
2025-01-16 7:36 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa580fc3-7b05-403b-b9f4-9c6d427e510a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox